Closed Bug 257 Opened 27 years ago Closed 24 years ago

FIX: Extra periods in filname changed to underscores

Categories

(MozillaClassic Graveyard :: Windows FE, defect, P3)

1998-03-31
x86
Windows NT

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 256

People

(Reporter: brian, Assigned: blythe)

Details

Created by Brian Wiles (brian@inforum.net) on Sunday, April 19, 1998 3:07:03 PM PDT Additional Details : I wrote my own fix to not change extra periods to underscores when downloading a file. Feel free to incorporate this into your version of Mozilla. Forgive me if this has been addressed previously. I did not see it in the Bugzilla query. This is a context diff in function fe_URLtoLocalName in ns\cmd\winfe\fenet.cpp: *** c:\temp\fenet.cpp Mon Mar 30 17:57:42 1998 --- fenet.cpp Sun Apr 19 14:45:30 1998 *************** *** 268,277 **** #endif char *name = csName.GetBuffer(0); ! // replace extra periods in 8 character name with underscores for (idx =0 ; idx < csName.GetLength(); idx++) { if ((name[idx] == '.')||(name[idx] == ':')) name[idx] = '_'; } csName.ReleaseBuffer(-1); *csURL = csName + csExt; --- 268,285 ---- #endif char *name = csName.GetBuffer(0); ! #ifdef XP_WIN16 ! // replace extra periods and colons in 8 character name with underscores for (idx =0 ; idx < csName.GetLength(); idx++) { if ((name[idx] == '.')||(name[idx] == ':')) name[idx] = '_'; } + #else + // replace extra colons in 8 character name with underscores + // This fixes the filename mangling problem in Win32 since it can handle multiple periods. -BCW 04/01/1998 + for (idx =0 ; idx < csName.GetLength(); idx++) { + if (name[idx] == ':') name[idx] = '_'; + } + #endif csName.ReleaseBuffer(-1); *csURL = csName + csExt; Updated by Brian Wiles (brian@inforum.net) on Sunday, April 19, 1998 3:12:46 PM PDT Additional Details : This is a duplicate of Bug # 256. I told Communicator to save the frame, and it reloaded it from the server, thus causing a repost of the same bug. -BCW Updated by (blythe@netscape.com) on Tuesday, June 9, 1998 4:11:53 PM PDT Additional Details : Assuming this is a duplicate of bug 256
mid-air collision ? / bugzilla cleanup Reopening (current State: resolved and no resolution)
Status: RESOLVED → REOPENED
dupe *** This bug has been marked as a duplicate of 256 ***
Status: REOPENED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
vrfy dup
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.