Closed Bug 26131 Opened 25 years ago Closed 24 years ago

Sorting threads in 3-pane is very slow

Categories

(MailNews Core :: Backend, defect, P1)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9

People

(Reporter: sol, Assigned: sspitzer)

References

Details

(Keywords: perf, Whiteboard: [nsbeta1+])

Attachments

(2 files)

Sorting threads in 3-pane is very slow. Build ID: 2000-01-31-11 Steps to reproduce: 1. Launch Mail 2. Select Inbox (mine contains about 2K messages) 3. Sort by date 4. Sort by sender Expected result: Sort operation is similar in speed to 4.7 Actual result: Sort operation is much, much slower (I would guess 5 to 10 times slower) Note: The speed of the sort seems loosely correlated with the size of the folder being sorted
Keywords: perf
QA Contact: lchiang → suresh
I'm marking beta1. According to the latest perf numbers, it takes about 8.2 seconds on a Windows target machine vs 1.51 in 4.7. I'm not sure that we should actually hold beta for this, but I think that if I find stuff that speeds this up, I should be allowed to check in. So I wouldn't mind having the PDT+ team's approval to do so.
Keywords: beta1
Whiteboard: [PDT+]
Whiteboard: [PDT+] → [PDT+]UNKNOWN
putting UNKNOWN in the status whiteboard. I could probably keep working on perf bugs until I'm told to stop.
In light of unknown difficulty, PDT- for beta1
Whiteboard: [PDT+]UNKNOWN → [PDT-]
marking M20 since this is probably going to be ongoing throughout the project.
Status: NEW → ASSIGNED
Target Milestone: M20
Suresh - can you post the latest numbers / timings here? Thanks.
Update on recent builds: Sorting by subject and reversing the sorting order takes ~8 seconds on the target machine.
moving to m18 and nominating nsbeta3 since this is something we said we are going to focus on.
Keywords: nsbeta3
Target Milestone: M20 → M18
Mail triage marking [nsbeta3+]
Whiteboard: [PDT-] → [PDT-][nsbeta3+]
Naoki, were you able to get this in?
Okay, I will check in the patch.
The idea struck for a small speed improvement: inverting a current sort doesn't require an actual re-sort... the column in question can just be inverted. For example, if a "Name" column is currently sorted in ascending order (1..n), and the user wants to sort descendingly on "Name" (from n..1), instead of resorting (touching RDF), the nodes in the content model can just be inversely shuffled. I worked up a diff and added some quick debugging time info (on Mac). I didn't see any speed improvement on a Mac for small folders (say around 100 items). Would anyone care to test this on a big mail folder (say 5,000 to 10,000 msgs) and get a timing to see if the code change is worthwhile? I'll attach the diff.
For this case this patch is really good. I tried a 5000 message local folder and had the following results: Sort by Sender: First = 3.815s Reversed = 1.713s Sort by Date: First = 2.704s Reversed = 1.742s And a 8839 message newsgroup: Sort by Sender: First = 8.022s Reversed = 3.344s Sort by Date: First = 4.937s Reversed = 3.495s
Thanks, Scott. Guess I'll check the changes in. nhotta, I'll check in your fix as well.
rjc - just wondering, did your patch ever get checked in? second pass: - per mail triage
Whiteboard: [PDT-][nsbeta3+] → [PDT-][nsbeta3-][cut 8/28]
lchiang: yes.
nominating for mail1
Keywords: mail1
Keywords: beta1nsbeta1
QA Contact: suresh → stephend
Keywords: nsbeta1
I've created bug 63759 which is a performance tracker bug for mail/news.
marking nsbeta1+ and moving to mozilla0.8 though it might get moved out as more research is done. reassigning to sspitzer
Assignee: putterman → sspitzer
Status: ASSIGNED → NEW
Keywords: nsbeta3nsbeta1
Priority: P3 → P1
Whiteboard: [PDT-][nsbeta3-][cut 8/28] → [nsbeta1+]
Target Milestone: M18 → mozilla0.8
*** Bug 65468 has been marked as a duplicate of this bug. ***
moving to mozilla0.9
Target Milestone: mozilla0.8 → mozilla0.9
OS/All, plus keywords.
OS: Windows 95 → All
fixed. hats off to hyatt, mscott and bienvenu. there is some room for improvement (in author sort and subject sort) but that will be covered in another bug.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
http://www.mozilla.org/mailnews/win_performance_results.html This is fixed in my latest testings. There is still room for improvement like Seth mentions, but in general, it's been improved by leaps and bounds. VERIFIED FIXED. That link cycles through Mac and Linux results, as well.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: