There are a few locations where "control" is used instead of "accel". "control" is mapped to the Control key on Mac, which shouldn't be used, according to http://www.mozilla.org/access/keyboard/#modifiers Instead, "accel" should be used, which is mapped to the Cmd key on Mac, the common shortcut key. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-sets.inc&rev=1.16.2.1.2.21&mark=274#274 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/search.xml&rev=1.16.4.4&mark=356,370#356 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/help/content/help.xul&rev=1.1.4.1.2.13&mark=134,136#134 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/tree.xml&rev=1.4&mark=329,338,478,496,570,578#329 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/content/download.xml&rev=1.11.6.3&mark=528#528

(In reply to comment #0) > There are a few locations where "control" is used instead of "accel". > "control" is mapped to the Control key on Mac, which shouldn't be used, > according to http://www.mozilla.org/access/keyboard/#modifiers > Instead, "accel" should be used, which is mapped to the Cmd key on Mac, the > common shortcut key. > > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-sets.inc&rev=1.16.2.1.2.21&mark=274#274 ctrl-F5 ==> cmd-F5 I'm not sure if this a good idea - it was always ctrl-reload even in Netscape 4, not cmd-reload. > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/search.xml&rev=1.16.4.4&mark=356,370#356 ctrl-up/down ==> cmd-up/down > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/help/content/help.xul&rev=1.1.4.1.2.13&mark=134,136#134 ctrl-tab ==> cmd-tab Impossible, conflicts with the OS > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/tree.xml&rev=1.4&mark=329,338,478,496,570,578#329 ctrl-up/down ==> cmd-up/down > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/content/download.xml&rev=1.11.6.3&mark=528#528 Eh ? this look like ctrl-cmd-n, but I think that the ctrl is ignored here.

> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/help/content/help.xul&rev=1.1.4.1.2.13&mark=134,136#134 > ctrl-tab ==> cmd-tab > Impossible, conflicts with the OS Ah, right, looks like Cmd+Tab switches applications. > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/content/download.xml&rev=1.11.6.3&mark=528#528 > Eh ? this look like ctrl-cmd-n, but I think that the ctrl is ignored here. I don't understand. The current code is Ctrl+N, which needs to be changed to Cmd+N. I don't have a Mac to try it though.

(In reply to comment #2) > http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/content/download.xml&rev=1.11.6.3&mark=528#528 > > Eh ? this look like ctrl-cmd-n, but I think that the ctrl is ignored here. > I don't understand. The current code is Ctrl+N, which needs to be changed to > Cmd+N. I don't have a Mac to try it though. I'm not at my Mac now, but I know that Cmd-N works. The definition of the line looks a bit strange (mentioning 'control', although it shouldn't do that).

Did you notice that this is for the Download Manager only? It lets you open a new browser window when you have closed all windows except the Download Manager. The key should be in downloads.xul, not downloads.xml by the way.

(In reply to comment #4) > Did you notice that this is for the Download Manager only? It lets you open a > new browser window when you have closed all windows except the Download Manager. > The key should be in downloads.xul, not downloads.xml by the way. Actually Cmd-N doesn't work at all when only the DM is open, but there bugs filed about that (mostly about menubar, like bug 245206).

Well, control+n does work in dm (not command+n), that's not related to the menu command. We do want change it to command+n, but i'm afraid it is going to have an ugly bug after the first time you open the file menu _in the download manager_.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-sets.inc&rev=1.16.2.1.2.21&mark=274#274 > > ctrl-F5 ==> cmd-F5 > I'm not sure if this a good idea - it was always ctrl-reload even in Netscape 4, > not cmd-reload. We muct change this one, since ctrl+f5 is the default keyboard shorctut for "Focus on Toolbar". We haven't implemented it, but unless you disable full-keyboard-acceess (or changes the default keyboard-shortcut), control+f5 won't work for force-reload.

*** Bug 263770 has been marked as a duplicate of this bug. ***

see also bug 263772

*** Bug 263772 has been marked as a duplicate of this bug. ***

-> Mano.

*** Bug 267958 has been marked as a duplicate of this bug. ***

(In reply to comment #11) > -> Mano. Sure

on the road to a real mac app ;)

Comment on attachment 169137 [details] [diff] [review] patch (checked in) a real mac app? scary

Checking in browser/base/content/search.xml; /cvsroot/mozilla/browser/base/content/search.xml,v <-- search.xml new revision: 1.19; previous revision: 1.18 done Checking in browser/base/content/browser-sets.inc; /cvsroot/mozilla/browser/base/content/browser-sets.inc,v <-- browser-sets.inc new revision: 1.31; previous revision: 1.30 done Checking in toolkit/content/widgets/tree.xml; /cvsroot/mozilla/toolkit/content/widgets/tree.xml,v <-- tree.xml new revision: 1.15; previous revision: 1.14 done

Bug 240696 (ctrl+n in the download manager) is not fixed on the trunk yet. So this bug is fixed.

*** Bug 280559 has been marked as a duplicate of this bug. ***

Except that the tree's key handlers only check for event.ctrlKey ...

So we need to consider replacing event.ctrlKey in a couple of places: http://lxr.mozilla.org/seamonkey/search?string=event.ctrlKey Does event.accelKey work? It's not been used anywhere...

Not a blocker, but I would still like to see the remaining bits of this fixed.

will work on it next week.

(In reply to comment #1) http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/help/content/help.xul&rev=1.1.4.1.2.13&mark=134,136#134 > > ctrl-tab ==> cmd-tab > Impossible, conflicts with the OS > On OS X, cmd-tab cycles apps while cmd-` cycles though an application's windows. If it's possible or desirable to have a completely different shortcut for the mac version, I would suggest cmd-option-` for cycling tabs. It's a principle known to the user that adding option to a shortcut provides an action that's related to the shortcut without (eg cmd-w close window, cmd-option-w close all windows).

(In reply to comment #23) > On OS X, cmd-tab cycles apps while cmd-` cycles though an application's windows. > If it's possible or desirable to have a completely different shortcut for the > mac version, I would suggest cmd-option-` for cycling tabs. It's a principle > known to the user that adding option to a shortcut provides an action that's > related to the shortcut without (eg cmd-w close window, cmd-option-w close all > windows). In Safari, it's cmd-shift-arrow.

in safari 1.3 (?) under 10.4.x Apple changed the "change tab" keys to command-shift-[ and command-shift-] (which matches Camino) because command-shift-arrow already had the semantics of being "select everything to the right/left".