Closed Bug 263853 Opened 20 years ago Closed 20 years ago

Neither Alt+down nor F4 key are listing the URLs from the address bar

Categories

(Firefox :: Keyboard Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: nosaku, Assigned: Gavin)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(3 obsolete files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1 F4 key is not listing the URLs from the address bar. In IE it show the list of all the URL from the address bar when F4 key is pressed (anywhere inside the window or within the address bar itself) Reproducible: Always Steps to Reproduce: 1. 2. 3. Actual Results: Should have listed the URLs
Alt+down appears to work.
Blocks: firekey
Severity: normal → minor
Keywords: access
Priority: -- → P5
(In reply to comment #1) > Alt+down appears to work. F4 doesn't work any more either.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: F4 key is not listing the URLs from the address bar → Neither Alt+down nor F4 key are listing the URLs from the address bar
Note: this works in Seamonkey's autocomplete widget.
Severity: minor → normal
Flags: blocking-aviary1.1+
Keywords: helpwanted
Priority: P5 → P3
Flags: blocking-aviary1.1+ → blocking-aviary1.1?
I've moved this up in priority because the URL bar is on the main screen and represents the first impression for the quality of our product.
Priority: P3 → P2
+ so long as you provide a patch ;-)
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Assignee: aaronleventhal → gavin.sharp
Keywords: helpwanted
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk
Attached patch Patch (obsolete) (deleted) — Splinter Review
Adds the F4 key to toggle the autocomplete dropdown's appearance. Only works when focus is in the location bar.
Status: NEW → ASSIGNED
I'm working on getting this to work globally.
(In reply to comment #7) > I'm working on getting this to work globally. You mean it would fix bug 283273 as well? (Search bar)
(In reply to comment #8) > You mean it would fix bug 283273 as well? (Search bar) The current patch works for all elements that use the autocomplete widget, so it does have an effect on the search bar. As you said in 283273 comment 1, however, the search bar has two different dropdowns and I'm not sure how the keyboard access should work in that case. This patch makes F4 toggle the dropdown history of previous searches. What this patch doesn't do, however, is let you use F4 anywhere in the browser to focus the location bar and toggle it's history dropdown, as in IE. That's what I meant by "working globally".
Comment on attachment 178058 [details] [diff] [review] Patch The Alt+Down & F4 keys should always do the same thing as clicking on the down pointing arrow. Gavin, are you still planning to work on this?
Attachment #178058 - Flags: review-
(In reply to comment #10) > Gavin, are you still planning to work on this? Yes, I'll try to do this tonight.
Attachment #178058 - Attachment is obsolete: true
Whiteboard: [patch-r?]
As far as I can tell the latest patch still doesn't work unless the address bar is focused. When the adress bar is focused it works as expected.
(In reply to comment #13) > As far as I can tell the latest patch still doesn't work unless the address bar > is focused. When the adress bar is focused it works as expected. I'm not so keen of emulating the behavior of IE where F4 works from anywhere. It just seems unnecessary. Alt+D gets you there. F4 can drop down the menu from there. If it's so important to emulate that, please file a separate RFE something like "F4 should drop down address bar URL list when web page focused"
Attachment #179637 - Flags: review?(mconnor) → review?(neil.parkwaycc.co.uk)
Comment on attachment 179637 [details] [diff] [review] add Alt+Down/Up and F4 as equivalents to the dropdown button Back to mconnor :)
Attachment #179637 - Flags: review?(neil.parkwaycc.co.uk) → review?(mconnor)
Blocks: deera11y
Comment on attachment 179637 [details] [diff] [review] add Alt+Down/Up and F4 as equivalents to the dropdown button >+ case KeyEvent.DOM_VK_F4: >+ this.toggleHistoryPopup(); >+ break; function keys are reserved on Mac, so this bit should be #ifndef XP_MACOSX r=me with that addresed
Attachment #179637 - Flags: review?(mconnor) → review+
Comment on attachment 179637 [details] [diff] [review] add Alt+Down/Up and F4 as equivalents to the dropdown button It will get checked in with the #ifdef XP_MACOSX
Attachment #179637 - Flags: approval-aviary1.1a1?
Attachment #179637 - Flags: approval-aviary1.1a1? → approval-aviary1.1a2?
Comment on attachment 179637 [details] [diff] [review] add Alt+Down/Up and F4 as equivalents to the dropdown button Should we be using F4 like that on OS X? Function keys are not really for app use over here, as I understand it.
Comment on attachment 179637 [details] [diff] [review] add Alt+Down/Up and F4 as equivalents to the dropdown button please #ifndef mac the F4 key.
Comment on attachment 179637 [details] [diff] [review] add Alt+Down/Up and F4 as equivalents to the dropdown button Sorry, I missed that comment when reading the patch and review request. Approved for 1.1a2, please wait to commit.
Attachment #179637 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Attached patch Updated patch [Checked in: Comment 22] (obsolete) (deleted) — Splinter Review
Aaron already said he'd check it in with the Mac check, but here's an update patch for good measure.
Attachment #184011 - Flags: review+
Attachment #184011 - Flags: approval-aviary1.1a2?
Whiteboard: [patch-r?] → [patch-r+][checkin needed]
Attachment #184011 - Attachment description: Update patch → Updated patch
Attachment #184011 - Flags: approval-aviary1.1a2?
Attachment #179637 - Attachment is obsolete: true
Checking in toolkit/content/widgets/autocomplete.xml; /cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v <-- autocomplete.xml new revision: 1.41; previous revision: 1.40 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #184011 - Attachment description: Updated patch → Updated patch [Checked in: Comment 22]
Attachment #184011 - Attachment is obsolete: true
Whiteboard: [patch-r+][checkin needed] → [patch-r+]
Whiteboard: [patch-r+]
*** Bug 250323 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: