Closed Bug 26782 Opened 25 years ago Closed 25 years ago

clicking delete in a tree doesn't cause JS function to get called

Categories

(Core :: XUL, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: slogan, Assigned: slogan)

Details

(Whiteboard: [PDT-] plus for beta2)

We have the following in our IM xul: <keyset id="keyset"> <!-- File Menu --> <key id="key_newNavigator"/> <key id="key_newMessage"/> <key id="key_newIM" key="&IMCmd.key;" observes="cmd_IM" disabled="false" shift="false" xulkey="true" alt="false"/> <key id="key_close"/> <key id="key_quit"/> <!-- Edit Menu --> <key id="key_undo"/> <key id="key_redo"/> <key id="key_cut"/> <key id="key_copy"/> <key id="key_paste"/> <key id="key_delete"/> <key id="key_selectAll"/> <key id="key_preferences"/> <key id="key_delete" keycode="VK_DELETE" shift="false" control="false" onkeypress="cmdDelete();"/> </keyset> This is similar to what mail news is using to capture delete key presses. The idea is we see these in the list setup of IM standalone and we call the JS function cmdDelete to delete the buddies or groups currently selected. This stopped working, we no longer get called. This is a beta1 feature for IM.
Whiteboard: beta1, dogfood
This is probably for saari
Assignee: hyatt → saari
Summary: clikcing delete in a tree doesn't cause JS function to get called → clicking delete in a tree doesn't cause JS function to get called
Clustering all these key bugs in hyatt's list since we will (in theory) be fixing most of them shortly
Assignee: saari → hyatt
syd, does this work in mailnews still? If so, I suspect silly XUL troubles and not an actual infrastructure bug.
Status: NEW → ASSIGNED
Maybe re-assigning it back to syd will cause him to see my comment. :)
Assignee: hyatt → syd
Status: ASSIGNED → NEW
Moving beta 1 and[DOGFOOD] in Status Summary to beta1, dogfood in keyword field.
Keywords: beta1, dogfood
Whiteboard: beta1, dogfood
Putting on PDT+ radar.
Whiteboard: [PDT+]
syd, need an ETA fora fix in the Status Whiteboard please. Thanks!
Status: NEW → ASSIGNED
Whiteboard: [PDT+] → [PDT+] 2/29/00
After talking with mscott, he sees this problem too, and has no idea what the problem might be. So, we probably both need hyatt to enlighten us.
Assignee: syd → hyatt
Status: ASSIGNED → NEW
Whiteboard: [PDT+] 2/29/00 → [PDT+] assigned back to hyatt
Reminder to fenella: When this bug is fixed, check bug 8985 for mail/news delete key. Add myself to cc list.
I have the same kind of problem in the attachment list (which is a tree) in message compose. I have a onkeypress handler which look for the delete key (0x08). It use to work on Mac but has never worked on PC:
I'm taking this
Assignee: hyatt → saari
Hey guys, if you put a tree in a toolbar, and don't explicitly override the user-focus CSS rule for toolbars (user-focus:ignore) then the tree won't get focus. IE no key events. Set the user-focus style to "normal". I tried this with the attachment tree in mail compose, and this fixed the problem. Tossing back to syd.
Assignee: saari → syd
hey saari....then why do we see this problem in the mailnews thread pane? the thread pane tree isn't inside of a toolbar in that case.
Also, Jean-Francois, can you add the style over-ride for the compose attachment pane and check it in under this bug so we can at least fix that part?
Yes I will. I have added those comment to bug 22338 which is about deleting attachment.
I don't see the problem in mailnews on my NT build from today. Are you hitting backspace and binding to delete by any chance? Delete works for me, backspace doesn't.
I'm removing the now outdated comment from the status whiteboard about "assigning to hyatt." Could you update the progress in a comment, and provide some potential landing date in the status whiteboard? For now, I'm adding the comment that this will become PDT- on 3/3
Whiteboard: [PDT+] assigned back to hyatt → [PDT+] w/b minus on 3/3
Past 3/3, so we're going to PDT- for beta1, PDT+ for beta2
Whiteboard: [PDT+] w/b minus on 3/3 → [PDT-] plus for beta2
*IGNORE* - massive spam changing open XPToolkit bug's QA contact to jrgm@netscape.com
QA Contact: paulmac → jrgm
This works for me in IM. Marking as such.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Putting on beta2 keyword radar since this was "plus for beta2" during beta1 triaging
Keywords: beta2
verified worksforme mac/linux/win32 20000418
Status: RESOLVED → VERIFIED
Keywords: nsbeta2
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.