Closed Bug 2703 Opened 26 years ago Closed 26 years ago

[PATCH] Dialog boxes

Categories

(Core :: Layout: Form Controls, defect, P2)

x86
Windows NT
defect

Tracking

()

VERIFIED WONTFIX

People

(Reporter: michael.j.lowe, Assigned: rods)

Details

Patch to change dialog boxes on Windows so they look like dialog boxes instead of floating windows: Index: nsDialog.cpp =================================================================== RCS file: /cvsroot/mozilla/widget/src/windows/nsDialog.cpp,v retrieving revision 1.7 diff -u -r1.7 nsDialog.cpp --- nsDialog.cpp 1998/09/30 18:59:31 1.7 +++ nsDialog.cpp 1999/01/22 12:50:52 @@ -40,6 +40,8 @@ NS_IMPL_ADDREF(nsDialog) NS_IMPL_RELEASE(nsDialog) +BOOL nsDialog::sIsRegistered = FALSE; + //------------------------------------------------------------------------- // // nsDialog constructor @@ -156,9 +158,31 @@ //------------------------------------------------------------------------- LPCTSTR nsDialog::WindowClass() { - return nsWindow::WindowClass(); + const LPCTSTR className = "NetscapeDialogClass"; + + if (!nsDialog::sIsRegistered) { + WNDCLASS wc; + +// wc.style = CS_HREDRAW | CS_VREDRAW | CS_DBLCLKS; + wc.style = CS_DBLCLKS | CS_SAVEBITS; + wc.lpfnWndProc = ::DefWindowProc; + wc.cbClsExtra = 0; + wc.cbWndExtra = 0; + wc.hInstance = nsToolkit::mDllInstance; + wc.hIcon = NULL; + wc.hCursor = NULL; + wc.hbrBackground = NULL; + wc.lpszMenuName = NULL; + wc.lpszClassName = className; + + nsDialog::sIsRegistered = ::RegisterClass(&wc); + } + + return className; } + + //------------------------------------------------------------------------- // // return window styles @@ -166,8 +190,7 @@ //------------------------------------------------------------------------- DWORD nsDialog::WindowStyle() { - //return DS_MODALFRAME; - return WS_CAPTION | WS_SYSMENU; + return WS_POPUP | WS_CAPTION | WS_SYSMENU; } //------------------------------------------------------------------------- @@ -177,9 +200,11 @@ //------------------------------------------------------------------------- DWORD nsDialog::WindowExStyle() { - //return WS_EX_DLGMODALFRAME; - return WS_EX_TOOLWINDOW | WS_EX_TOPMOST; + //return WS_EX_TOOLWINDOW | ; + return WS_EX_DLGMODALFRAME | WS_EX_TOPMOST; } + + //------------------------------------------------------------------------- // Index: nsDialog.h =================================================================== RCS file: /cvsroot/mozilla/widget/src/windows/nsDialog.h,v retrieving revision 1.5 diff -u -r1.5 nsDialog.h --- nsDialog.h 1998/09/28 22:32:36 1.5 +++ nsDialog.h 1999/01/22 12:50:53 @@ -66,7 +66,7 @@ static BOOL CALLBACK NSDialogProc (HWND hDlg, UINT iMsg, WPARAM wParam, LPARAM lParam); - + static BOOL sIsRegistered; }; #endif // nsDialog_h__
Setting all current Open/Normal to M4.
per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WONTFIX
I think this is a not implemented yet bug. Work is being done by danm.
Status: RESOLVED → VERIFIED
since dialog boxes are currently being implemented elsewhere, i'm verifying this.
Moving all Widget Set bugs, past and present, to new HTML Form Controls component per request from karnaze. Widget Set component will be retired shortly.
Keywords: patch
You need to log in before you can comment on or make changes to this bug.