We need to make 'newchangedmail' into a template instead of a parameter. See the patches on bug 84876 for hints and implementations.

Kerio would like this, so I'll try to get it in for 2.20.

The trunk is now frozen to prepare Bugzilla 2.22. Enhancement bugs are retargetted to 2.24.

Comment on attachment 233258 [details] [diff] [review] batosti_v1_fix Looks good. I saw no regression. r=LpSolit

Comment on attachment 233258 [details] [diff] [review] batosti_v1_fix Don't use terms.Bugzilla in the headers. If they make it into something with a space, it will break email. They're headers--users don't see them. Just keep them standard across all Bugzillas by not renaming them.

Comment on attachment 233258 [details] [diff] [review] batosti_v1_fix Also, why in the world did you do Bugzilla::Template->create()??? Use Bugzilla->template!

(In reply to comment #7) > (From update of attachment 233258 [details] [diff] [review] [edit]) > Also, why in the world did you do Bugzilla::Template->create()??? Use > Bugzilla->template! > batosti said that using Bugzilla->template was conflicting with the current template being processed, e.g. in process_bug.cgi when process.html.tmpl calls bugmail.html.tmpl.

This fix in 009bugwords.t will be required to not complain about X-Bugzilla.

Comment on attachment 233313 [details] [diff] [review] Do not complain about X-Bugzilla Yeah, LpSolit explained on IRC that ?<! means "find this regex only if it doesn't start with these characters."

Why not just using the syntax used in bug 135812 X-B[%#%]ugzilla-Type:

i use Bugzilla::Template->create() instead Bugzilla->template because the bugmail is called by a template and if i call the process method from Bugzilla->template it's rewirte the actual template and an error is given.

(In reply to comment #11) > Why not just using the syntax used in bug 135812 > > X-B[%#%]ugzilla-Type: > Because that's a ugly hack

Comment on attachment 233588 [details] [diff] [review] batosti_v2 I checked that replacing Bugzilla::Template->create() by Bugzilla->template generates an error. We should remove SendBugMail from Template.pm IMO, which is only used in template/en/default/bug/process/bugmail.html.tmpl Nit: probably should we 'use Bugzilla::Template' from BugMail.pm. Not sure this is required though. r=LpSolit

Checking in Bugzilla/BugMail.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v <-- BugMail.pm new revision: 1.88; previous revision: 1.87 done Checking in Bugzilla/Config/MTA.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v <-- MTA.pm new revision: 1.10; previous revision: 1.9 done Checking in t/009bugwords.t; /cvsroot/mozilla/webtools/bugzilla/t/009bugwords.t,v <-- 009bugwords.t new revision: 1.4; previous revision: 1.3 done Checking in template/en/default/admin/params/mta.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/mta.html.tmpl,v <-- mta.html.tmpl new revision: 1.6; previous revision: 1.5 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v done Checking in template/en/default/email/newchangedmail.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v <-- newchangedmail.txt.tmpl initial revision: 1.1 done