Closed
Bug 278036
Opened 20 years ago
Closed 20 years ago
nsXULTextField should have "activate" action
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Louie.Zhao, Assigned: Louie.Zhao)
References
Details
(Whiteboard: sunport17)
Attachments
(1 file)
|
(deleted),
patch
|
pkwarren
:
review+
Henry.Jia
:
superreview+
|
Details | Diff | Splinter Review |
Steps to Reproduce:
1. Start GOK and launch Mozilla.
2. In GOK main window, click menus->Bookmark->Bookmark Manager.
3. In GOK main window, click UI Grab.
Bug Observation:
The "Search" item in the GOK UI-Grab should be active
XUL textfield has no action defined and GOK can't grab any element without action.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Whiteboard: sunport17
|
|
Assignee | |
Updated•20 years ago
|
Attachment #170992 -
Flags: review?(pkwarren)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 170992 [details] [diff] [review]
patch v1
>Index: accessible/src/xul/nsXULFormControlAccessible.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/xul/nsXULFormControlAccessible.cpp,v
>retrieving revision 1.41
>diff -p -u -5 -r1.41 nsXULFormControlAccessible.cpp
>--- accessible/src/xul/nsXULFormControlAccessible.cpp 1 Jul 2004 20:43:03 -0000 1.41
>+++ accessible/src/xul/nsXULFormControlAccessible.cpp 12 Jan 2005 05:21:30 -0000
...
>+ return NS_OK;;
Remove the extra semicolon.
Everything else looks great.
Attachment #170992 -
Flags: review?(pkwarren) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #170992 -
Flags: superreview?(Henry.Jia)
Attachment #170992 -
Flags: superreview?(Henry.Jia) → superreview+
|
|
||
Comment 3•20 years ago
|
||
Louie - this patch should be ready to be checked in now.
|
|
Assignee | |
Comment 4•20 years ago
|
||
Thanks for r & sr. Patch checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•