Closed
Bug 283000
Opened 20 years ago
Closed 20 years ago
Remove app-specific #ifdefs from nsContentTreeOwner.cpp
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: neil, Unassigned)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review-
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
Ostensibly for bug 215296 hyatt added an #ifdef into nsContentTreeOwner.cpp so
that Firefox window titles would not have the " - Firefox" suffix although
untitled documents would still generate a Firefox title. Surely it would have
been better to #ifdef the chrome files instead?
|
Reporter | |
Comment 1•20 years ago
|
||
Attachment #174995 -
Flags: superreview?(bryner)
Attachment #174995 -
Flags: review?(mconnor)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 174995 [details] [diff] [review]
Like this
sr=dveditz
Attachment #174995 -
Flags: superreview?(bryner) → superreview+
|
||
Comment 3•20 years ago
|
||
Neil: didn't you need to update viewSource.xul?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 174995 [details] [diff] [review]
Like this
This means that any extensions out there have to preprocess or otherwise set
these values manually, meaning that it probably won't get done right, and OS X
users will get the title modifier. As noted on IRC, this might be something
seamonkey should do as well.
Attachment #174995 -
Flags: review?(mconnor) → review-
|
|
Reporter | |
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•