See bug 101995. The api for doing this was changed a few years back, and it looks like no one ever updated the firefox bookmark fork. Marking dependent, since there is a proposed api change in bug 101995, but we should really just fix this to do what seamonkey does and then change as needed if the api changes.

Quick summary of this: 1) User visits site, we misguess the charset, user manually sets the charset and it works, and then bookmarks the site. 2) User visits the site again, and has to reset the charset again each time. 3) User smash Firefox

I filed bug 337962 on problems I found in the xpfe version.

I tested this with NHL.com (which doesn't specify an encoding), in a new profile: 1) Go to NHL.com, check that the page encoding is the default (ISO-8859-1 in my case) using the View->Character Encoding menu. 2) Change the character encoding to "Western (Windows-1252)" using the menu. 3) Bookmark the page. 4) Restart the browser. 5) Clear the cache. 6) Visit NHL.com, verify that the character encoding is "Western (Windows-1252)". That test fails without this patch, and succeeds with it.

Comment on attachment 223565 [details] [diff] [review] patch r+a=me, pending bz's SR

Comment on attachment 223565 [details] [diff] [review] patch Looks reasonable... Why did you need to require chardet, though?

Fixed on the branch. The trunk doesn't build this code, it will be fixed in bug 317472, so closing off this bug.

Reopening just to make double-extra-sure we remember to get a trunk landing, now that trunk's going to ship non-Places.

(And, not that you were going to, but don't forget about bug 341277)

mozilla/browser/components/build/nsModule.cpp 1.45 mozilla/browser/components/build/Makefile.in 1.47 mozilla/browser/components/bookmarks/src/nsBookmarksService.h 1.26 mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp 1.89 mozilla/browser/components/bookmarks/src/Makefile.in 1.20