Closed
Bug 290714
Opened 20 years ago
Closed 20 years ago
Don't use reserved const names in bookmarks/content
Categories
(Firefox :: Bookmarks & History, defect, P1)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
This blocks the fix for 239218.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox1.1
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #180964 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Summary: Don't use reserved const named in bookmarks/content → Don't use reserved const names in bookmarks/content
Updated•20 years ago
|
Attachment #180964 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 180964 [details] [diff] [review]
patch
Requesting 1.1a approval, this one is blocking the fix for bug 239218.
Attachment #180964 -
Flags: approval-aviary1.1a?
Comment 3•20 years ago
|
||
Comment on attachment 180964 [details] [diff] [review]
patch
a=asa
Attachment #180964 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Assignee | ||
Comment 4•20 years ago
|
||
Checking in addBookmark2.js;
/cvsroot/mozilla/browser/components/bookmarks/content/addBookmark2.js,v <--
addBookmark2.js
new revision: 1.34; previous revision: 1.33
done
Checking in bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v <--
bookmarks.js
new revision: 1.98; previous revision: 1.97
done
Checking in bookmarksManager.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksManager.js,v <--
bookmarksManager.js
new revision: 1.19; previous revision: 1.18
done
Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v <--
bookmarksMenu.js
new revision: 1.43; previous revision: 1.42
done
Checking in bookmarksProperties.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksProperties.js,v
<-- bookmarksProperties.js
new revision: 1.21; previous revision: 1.20
done
Checking in bookmarksTree.xml;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksTree.xml,v <--
bookmarksTree.xml
new revision: 1.66; previous revision: 1.65
done
Checking in selectBookmark.js;
/cvsroot/mozilla/browser/components/bookmarks/content/selectBookmark.js,v <--
selectBookmark.js
new revision: 1.14; previous revision: 1.13
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 5•20 years ago
|
||
This check-in appears to render the sage extension inoperative.
Comment 6•20 years ago
|
||
Well, we're about to bump the appversion for extensions, so that shouldn't be
such a big deal. This is needed to enable things for Mac that were horribly broken.
Can we confirm that this *won't* go into a 1.0+ build, only into 1.1+? Just
trying to figure out if hosting two extension versions based on the FF version
is going to be sufficient.
Comment 8•18 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•