Closed
Bug 293235
Opened 20 years ago
Closed 19 years ago
When fastback is enabled and back button (or keyboard) is used, visited links are not marked as visited
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: phiw2, Assigned: bryner)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050507 Firefox/1.0+ (phiw13)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050507 Firefox/1.0+ (phiw13)
Since the landing of bug 274784, when using the backbutton, a link that just has
been visited is not marked/displayed as visited.
Visit the test page, follow the link, and use the backbutton to come back. The
link will have still be focussed (a:focus); that is OK. Once it loses the focus
(clicking anywhere to shift the focus, it will still be blue (a:link), whereas I
expect it to be green (a:visited).
[Reloading the page, and the link will turn green.]
Sidenote - Opera 8beta for OS X turns the link green. Right now, I've no access
to a windows box to test Opera 8 win.
Reproducible: Always
Steps to Reproduce:
1.load test case
2.follow link (the top one is OK).
3.use backbutton or keyboard to step back to first page
Actual Results:
the link has still focus (OK), once deselected, it displays as blue (the color
assigned to a:link).
Expected Results:
Display the link as green (the color assigned by a:visited).
Both official nightly and my own build. New profile, empty cache for testing
purposes.
Reporter | ||
Comment 1•20 years ago
|
||
Forgot to add: browser.sessionhistory.max_viewers is set to 5.
Comment 2•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050506
Firefox/1.0+
I see this too, when bfcache is enabled.
Updated•20 years ago
|
Severity: major → normal
Summary: [regression] when using the back button (or keyboard), visited links are not marked as visited → when using the back button (or keyboard), visited links are not marked as visited
Comment 4•20 years ago
|
||
(In reply to comment #3)
> bug 78510 would probably fix this
Should this be marked as a dependency one way or the other?
Comment 5•20 years ago
|
||
This is only for workaround. Mark link visited as link is middle-clicked.
This patch has same problem as middle-clicking link; a link which actually
clicked is only marked as visited, other links which have same URI are still
shown as unvisited.
Comment 6•19 years ago
|
||
Also, just wondering, but if the same link is in other places on the same page,
those are not marked either, just the original. Thanks.
Comment 7•19 years ago
|
||
(In reply to comment #6)
> Also, just wondering, but if the same link is in other places on the same page,
> those are not marked either, just the original. Thanks.
I believe that's bug 78510.
Assignee | ||
Comment 8•19 years ago
|
||
This doesn't depend on 78510. We can reresolve style on links when restoring a
page.
No longer depends on: 78510
Updated•19 years ago
|
Flags: blocking1.8b4+
Flags: blocking1.8b3?
Flags: blocking1.8b3-
Flags: blocking-aviary1.1?
Flags: blocking-aviary1.1+
Keywords: regression
Comment 9•19 years ago
|
||
At this risk of this being considered bugspam, is there anyway this can be fixed
for 1.8b3? I realize the blocking flag has been minused, so will not nominate
again, but this does appear to be probably the single issue that are large
number of people have an issue with in the daily use of "blazingfastback".
Assuming this cannont be fixed for 1.8b3, I think clearly documenting the issue
in release notes (for the 5% of people that read them) would be good
Comment 10•19 years ago
|
||
*** Bug 299869 has been marked as a duplicate of this bug. ***
Depends on: 78510
Comment 11•19 years ago
|
||
*** Bug 301001 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Summary: when using the back button (or keyboard), visited links are not marked as visited → When fastback is enabled and back button (or keyboard) is used, visited links are not marked as visited
Assignee | ||
Comment 12•19 years ago
|
||
Targetting to match blocking status (and get off the
untargetted-fastback-dependencies list).
Target Milestone: --- → mozilla1.8beta4
*** Bug 302154 has been marked as a duplicate of this bug. ***
Comment 14•19 years ago
|
||
bryner, can you fix it the "right way" in the next week? or should we take the
workaround?
/cb
Assignee: nobody → bryner
Comment 15•19 years ago
|
||
*** Bug 302431 has been marked as a duplicate of this bug. ***
*** Bug 303131 has been marked as a duplicate of this bug. ***
Comment 17•19 years ago
|
||
(In reply to comment #16)
> *** Bug 303131 has been marked as a duplicate of this bug. ***
Can someone mark this as fixed,
https://bugzilla.mozilla.org/show_bug.cgi?id=78510 has just been checked in and
fixes this bug
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
Comment 18•15 years ago
|
||
Attachment #387544 -
Flags: review?(bzbarsky)
Comment 19•15 years ago
|
||
Comment on attachment 387544 [details] [diff] [review]
mochitest test case
Nice.
Attachment #387544 -
Flags: review?(bzbarsky) → review+
Comment 20•15 years ago
|
||
Pushed test as http://hg.mozilla.org/mozilla-central/rev/36757da19bbb
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•