Closed
Bug 294926
Opened 20 years ago
Closed 20 years ago
middle-click on link gives autoscroll icon; does not open link
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: u88484, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
dbaron
:
approval1.8b2+
|
Details | Diff | Splinter Review |
When middle-clicking on a link the icon and scroll arrows for autoscroll appear
instead of opening the link in a new tab...regression
Keywords: regression
Summary: middle-click on link gives autoscroll icon; does not open link → middle-click on link gives autoscroll icon; does not open link
Updated•20 years ago
|
Component: Tabbed Browser → XPConnect
Comment 1•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+
I can confirm this. Also Right-Click, then Open in new Tab doesn't work. I
expect this is related.
Comment 2•20 years ago
|
||
*** Bug 294930 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Assignee: nobody → dbradley
Comment 3•20 years ago
|
||
Without autoscroll enabled, middle click functions as normal.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052009
Assignee | ||
Updated•20 years ago
|
Comment 4•20 years ago
|
||
right click> open in new tab works for me. 14:41 build
Comment 5•20 years ago
|
||
This works for me with fixes checked in today, not yet in respins, for bug 281988.
/be
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 6•20 years ago
|
||
Note: You have to have Tools > Options > Advanced > General > Use Auto-scroll
enabled to see the middle-clicking-a-link-not-working bug.
Comment 7•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052013
Still broken, are there other fixes to go in or should this have been fixed in
this build.
Apologies if you meant that the fixes are still to be checked in.
-> Reopen in case it should be fixed by earlier checkins
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052014
With Tools > Options > Advanced > General > Use Auto-scroll ticked, middle
clicking on a link still pops the Auto-scroll icon rather than opening the link
in a new tab like it used to.
Comment 9•20 years ago
|
||
Yeah, fresh build from a 40 minute-old checkout shows the same thing here.
Comment 10•20 years ago
|
||
very annoying bug indeed.
Comment 11•20 years ago
|
||
FYI. Using All-In-One Gestures 0.14.3 with "All-In-One autoscroll" set, this
doesn't happen. With "Native autoscroll" set, problem manifests.
Comment 13•20 years ago
|
||
Assignee | ||
Comment 14•20 years ago
|
||
The problem is that instanceof is returning false across the board for
XPCNativeWrappers.
Comment 15•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+
Still shows up on the 21st's build.
Comment 16•20 years ago
|
||
Need an easy way to test "system" scripts. If someone can make a reduced
testcase for Firefox, please lay it on this bug.
/be
Assignee | ||
Comment 17•20 years ago
|
||
Apply this, rebuild in browser/, start firefox, right-click on an HTML page.
instanceof isn't broken for Components.interfaces.nsIFoo because the relevant
hasInstance hook deals.
The problem here is that DOMJSClass_HasInstance does _not_ deal: it gets an
XPCNativeWrapper JSObject, gets its class, and tries to return a value based on
that, which naturally doesn't work.
I suppose we could manually get the wrapped JSObject here or something... Need
to expose a way to tell that we're dealing with an XPCNativeWrapper if we do
that. And we might have to fix the various other hasInstance hooks too (eg
liveconnect, maybe jsxml, etc).
Assignee | ||
Comment 18•20 years ago
|
||
Attachment #184266 -
Flags: superreview?(jst)
Attachment #184266 -
Flags: review?(jst)
Comment 19•20 years ago
|
||
Comment on attachment 184266 [details] [diff] [review]
Patch per discussion with jst
r+sr=jst
Attachment #184266 -
Flags: superreview?(jst)
Attachment #184266 -
Flags: superreview+
Attachment #184266 -
Flags: review?(jst)
Attachment #184266 -
Flags: review+
Assignee | ||
Comment 20•20 years ago
|
||
Comment on attachment 184266 [details] [diff] [review]
Patch per discussion with jst
Fixes instanceof regression with the new security stuff.
Attachment #184266 -
Flags: approval1.8b2?
Updated•20 years ago
|
Attachment #184266 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Updated•20 years ago
|
Assignee: dbradley → bzbarsky
Severity: critical → normal
Status: REOPENED → NEW
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Comment 21•20 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Comment 22•20 years ago
|
||
(In reply to comment #21)
> Fixed.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050522
Firefox/1.0+
Verified Fixed in the latest hourly on WinXP
Comment 23•20 years ago
|
||
*** Bug 294921 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Flags: blocking1.8b2?
You need to log in
before you can comment on or make changes to this bug.
Description
•