Closed Bug 295520 Opened 20 years ago Closed 20 years ago

Page Info Security tab broken for pages with frames

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows XP
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: pawel.worach, Assigned: jst)

References

()

Details

(Keywords: regression)

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525 Firefox/1.0+ The page info security tab is blank and the "View" button does nothing. This only happens for pages with frames such as the URL above and even this bug-entry page that has an iframe with the bug list. If you click in the frame and do "Show only this frame" the security tab looks good. No error in the JS console. Also double clicking the padlock in the status bar does not open the "Security" tab automatically but the "General" tab, don't know if it's related to this but it works on non-framed pages. Reproducible: Always Steps to Reproduce: 1. Go to a SSL page with frames such as https://eredovisning.plusgirot.se/ddrint/nordea/LoginFrame.jsp https://www.soft.nordea.se/soft/index.html or https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox 2. Right click on page, click "View Page Info" in context menu. 3. Click Security tab. Actual Results: The security tab is blank and the "View" button does not work. Expected Results: Security tab displaying cipher information and "View" button displaying certificate details.
Attached image Screenshot of broken Security tab (deleted) —
Win32 installer trunk builds tested and result: 2005-05-19-07-trunk OK 2005-05-21-07-trunk OK <no closer match found with nightly builds> 2005-05-21-22-trunk Broken 2005-05-22-15-trunk Broken 2005-05-23-06-trunk Broken
WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521 Firefox/1.0+ ID:2005052104 BKN Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521 Firefox/1.0+ ID:2005052110
Status: UNCONFIRMED → NEW
Ever confirmed: true
I'm thinking the wrappers bug is a more likely candidate, the parser shouldn't have an effect on something like this.
Keywords: regression
Version: unspecified → Trunk
Version: unspecified → Trunk
Blocks: 294984
Javascript console error: Error: aWindow.frames[i] has no properties Source File: chrome://browser/content/pageInfo.js Line: 432 That line: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/pageInfo.js&mark=472#466
Blocks: 281988
No longer blocks: 294984
Assignee: nobody → general
Component: Security → DOM: Level 0
Product: Firefox → Core
QA Contact: firefox → ian
Assignee: general → jst
Comment on attachment 184554 [details] [diff] [review] Define properties by index when resolved so that callers see the properties before getting the value. >Index: dom/src/base/nsDOMClassInfo.cpp >+ // A numeric property accessed and the numeric proerty is a s/proerty/property/ > nsWindowSH::NewResolve(nsIXPConnectWrappedNative *wrapper, JSContext >+ // If we're resolving a numeric property. Treat that as if Comma before "treat", please -- the part up to "property" is not a sentence. >+ // A numeric property accessed and the numeric proerty is a "property" >+ // child frame. Define a property for this index. r+sr=bzbarsky
Attachment #184554 - Flags: superreview?(bzbarsky)
Attachment #184554 - Flags: superreview+
Attachment #184554 - Flags: review?(bzbarsky)
Attachment #184554 - Flags: review+
Attachment #184554 - Flags: approval1.8b2?
Attachment #184554 - Flags: approval1.8b2? → approval1.8b2+
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: