Closed
Bug 300006
Opened 19 years ago
Closed 19 years ago
"cookies need value" error code when a query returns an empty result.
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: altlist, Assigned: Wurblzap)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
With the latest tip, I'm seeing a cookies_need_value error code when a query
returns an empty list. That's because Bugzilla::CGI::send_cookie is expecting a
value for the "-value" key, but buglist is sending an empty string.
I don't know what's the best way to fix it, but will enclose a simple patch that
worked for me.
This is probably a show stopper for 2.20. Apologies if this is a dup, couldn't
find a related ticket.
Reproducible: Always
Steps to Reproduce:
Reporter | ||
Comment 1•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Summary: "cookies need value" error code when a query returns an empty result. → "cookies need value" error code when a query returns an empty result.
Assignee | ||
Comment 2•19 years ago
|
||
This is a regression of bug 268146.
Assignee: query-and-buglist → altlst
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking2.20?
Flags: blocking2.18.2?
Keywords: regression
Target Milestone: --- → Bugzilla 2.18
Assignee | ||
Comment 3•19 years ago
|
||
Your patch is the right way to go, and it fixes the issue at hand.
Can you check whether there are other places similarly broken? I found one:
o In a bug list, press "Change Columns"
o Uncheck all check marks
o Press "Change Columns"
If you don't find the time to validate (and, if necessary, fix) other
send_cookie callsites, then please request review on your patch from me, and
I'll set r+ and fix the other places myself in other bugs.
Assignee | ||
Comment 4•19 years ago
|
||
I checked the other places.
What'll happen if you remove all checkmarks in colchange.cgi now is that you'll
get your column list reset to the bz default.
Assignee: altlst → wurblzap
Attachment #188588 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #188598 -
Flags: review?
Reporter | ||
Comment 5•19 years ago
|
||
> I checked the other places.
You beat me to the punch. But yup, I didn't see any other send_cookie problems.
> What'll happen if you remove all checkmarks in colchange.cgi now is that you'll
> get your column list reset to the bz default.
That's what I'm seeing as well.
Updated•19 years ago
|
Flags: blocking2.20?
Flags: blocking2.20+
Flags: blocking2.18.2?
Flags: blocking2.18.2+
Comment on attachment 188598 [details] [diff] [review]
Patch for HEAD and branch
r=glob
> my $list = join(" ", @collist);
> my $urlbase = Param("urlbase");
>
>- $cgi->send_cookie(-name => 'COLUMNLIST',
>- -value => $list,
>- -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
>+ if ($list) {
>+ $cgi->send_cookie(-name => 'COLUMNLIST',
nit: i think this would be clearer as
if (@collist) {
Attachment #188598 -
Flags: review? → review+
Updated•19 years ago
|
Flags: approval?
Flags: approval2.18?
Updated•19 years ago
|
Version: unspecified → 2.18.1
Updated•19 years ago
|
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+
Comment 7•19 years ago
|
||
I checked in this patch so that we can release tonight.
Tip:
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi
new revision: 1.299; previous revision: 1.298
done
Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v <-- colchange.cgi
new revision: 1.49; previous revision: 1.48
done
2.18:
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi
new revision: 1.255.2.10; previous revision: 1.255.2.9
done
Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v <-- colchange.cgi
new revision: 1.41.2.4; previous revision: 1.41.2.3
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•