Closed
Bug 301476
Opened 19 years ago
Closed 19 years ago
Should XPC_NW_CheckAccess always call the checkAccess hook on the wrapped native?
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: jst)
References
Details
(Keywords: fixed1.8, Whiteboard: [ETA 8/11])
Attachments
(1 file)
|
(deleted),
patch
|
shaver
:
review+
brendan
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
I don't see why XPCWrappedNative should only call the checkAccess hook on the
underlying native wrapper in the bypass case. It seems to me that we'd
basically want to do this any time... but maybe I'm missing something?
|
Reporter | |
Comment 1•19 years ago
|
||
I think we need to at least think about this for 1.8b4
Flags: blocking1.8b4?
|
||
Comment 3•19 years ago
|
||
jst -> dveditz supposes that this is related to split windows. Would you mind
taking a look to see if it should block the beta?
Assignee: dbradley → jst
|
Assignee | |
Comment 4•19 years ago
|
||
Better safe than sorry, and I can't think of a case where we *don't* want this.
Attachment #192144 -
Flags: superreview?(brendan)
Attachment #192144 -
Flags: review?(shaver)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [ETA 8/11]
|
||
Comment 5•19 years ago
|
||
Comment on attachment 192144 [details] [diff] [review]
Unconditionally forward checkAccess() calls to the wrapped native's JSObject.
The canonical name for clazz is clasp, of course ;-). sr=me in any case.
/be
Attachment #192144 -
Flags: superreview?(brendan) → superreview+
|
|
Assignee | |
Comment 6•19 years ago
|
||
The jband-canonical name for clasp is clazz :)
Status: NEW → ASSIGNED
Comment on attachment 192144 [details] [diff] [review]
Unconditionally forward checkAccess() calls to the wrapped native's JSObject.
r=shaver
Attachment #192144 -
Flags: review?(shaver) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #192144 -
Flags: approval1.8b4?
|
|
Assignee | |
Comment 8•19 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•19 years ago
|
Attachment #192144 -
Flags: approval1.8b4? → approval1.8b4+
|
|
||
Updated•19 years ago
|
Flags: blocking1.8b4?
You need to log in
before you can comment on or make changes to this bug.
Description
•