Closed Bug 301762 Opened 19 years ago Closed 18 years ago

Block browser from port 993 (IMAP over SSL)

Categories

(Core :: Security, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8.1beta1

People

(Reporter: jruderman, Assigned: dveditz)

References

()

Details

(Keywords: verified1.8.1, Whiteboard: [sg:low])

Attachments

(1 file, 1 obsolete file)

Since Firefox doesn't allow connections over port 143 (IMAP), it should also disallow connections over port 993 (IMAP over SSL). I imagine that any exploits where http traffic is treated as IMAP traffic also work when https traffic is treated as IMAP-over-SSL traffic. Steps to reproduce: 1. Load https://turing.cs.hmc.edu:993/ Result: * OK Courier-IMAP ready. Copyright 1998-2003 Double Precision, Inc. See COPYING for distribution information. GET NO Error in IMAP command received by server. Host: NO Error in IMAP command received by server. User-Agent: NO Error in IMAP command received by server. Accept: NO Error in IMAP command received by server. Accept-Language: NO Error in IMAP command received by server. Accept-Encoding: NO Error in IMAP command received by server. Accept-Charset: NO Error in IMAP command received by server. Keep-Alive: NO Error in IMAP command received by server. Connection: NO Error in IMAP command received by server. * BYE [ALERT] Fatal error: TOO MANY CONSECUTIVE PROTOCOL VIOLATIONS: The server seems to treat each line of the http request header as a command. With POST and a slightly more lenient server (or a proxy that reduces the number of headers), an attacker might be able to get a user's browser to send arbitrary IMAP commands to an IMAP server.
http://support.microsoft.com/default.aspx?scid=kb;en-us;278339 lists the SSL ports used by the Microsoft Exchange mail server. Anyone know the hostname of an Exchange server I can poke at?
https://turing.cs.hmc.edu:995/ (POP over SSL) +OK Qpopper (version 4.0.3) at turing starting. <24580.1122062855@turing> -ERR Unknown command: "get". -ERR Unknown command: "host:". -ERR Too many arguments supplied. -ERR Unknown command: "accept:". -ERR Unknown command: "accept-language:". -ERR Unknown command: "accept-encoding:". -ERR Unknown command: "accept-charset:". -ERR Unknown command: "keep-alive:". -ERR Unknown command: "connection:". -ERR POP timeout from turing +OK Pop server at turing signing off.
Flags: blocking1.8b4?
Dan, can you take care of this, either plus or minus and help it get assigned if we plus it?
Whiteboard: [sg:investigate]
Dan, please plus if you think we have to have this for 1.5. Thanks.
Flags: blocking1.8b4? → blocking1.8b4-
Attached patch add standard SSL mail ports (obsolete) (deleted) — Splinter Review
Attachment #225872 - Flags: superreview?(darin)
Attachment #225872 - Flags: review?
Attachment #225872 - Flags: review? → review?(dougt)
Status: NEW → ASSIGNED
Flags: blocking1.8.1?
Whiteboard: [sg:investigate] → [sg:low]
Comment on attachment 225872 [details] [diff] [review] add standard SSL mail ports I see no problem with this. Don't you also have to change the AllowPort() function in for those schemes that want to use these ports?
Attachment #225872 - Flags: superreview?(darin) → superreview+
Flags: blocking1.8.1? → blocking1.8.1+
Attachment #225872 - Flags: review?(dougt)
Attached patch as above plus ldap SSL (deleted) — Splinter Review
Forgot the ldap ssl port. carrying over darin's SR: non-substantive change and he'll get a chance to object with the 1.8.1 approval request. To answer Doug's question, the mail protcols simply allow every port and LDAP already checks for the normal and SSL ports listed here. No AllowPort() changes are necessary.
Attachment #225872 - Attachment is obsolete: true
Attachment #225963 - Flags: superreview+
Attachment #225963 - Flags: review?(dougt)
Attachment #225963 - Flags: approval-branch-1.8.1?(darin)
Attachment #225963 - Flags: approval-branch-1.8.1?(darin)
Attachment #225963 - Flags: review?(dougt) → review+
Comment on attachment 225963 [details] [diff] [review] as above plus ldap SSL a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH promptly and add the fixed1.8.1 keyword to the bug)
Attachment #225963 - Flags: approval1.8.1+
Please land this ASAP so that it does not hold up the FF2 beta1 release. Or, if we should ship FF2 beta1 without this fix then please let us know.
Target Milestone: --- → mozilla1.8.1beta1
Whiteboard: [sg:low] → [sg:low][checkin needed]
Fix checked in to trunk and 1.8 branch
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [sg:low][checkin needed] → [sg:low]
Great. You just broke the ability for any FireFox user to LOOK AT the certificates from his IMAPS or POPS server using his browser. https://lunarpages.com:993/ doesn't work any more. Users will no longer be able to use this simple technique to see what's wrong with their email server certificates. Sure seems like changes like this ought to be discussed in mozilla security mailing list first.
ff2b2 windows/linux localhost:993 -> This address is restricted
Flags: blocking1.8.0.8?
In case people have written web apps (internal?) that use these ports we don't want that kind of breakage to prevent people from taking a security fix. This low-impact problem shouldn't get fixed in 1.8.0.x
Flags: blocking1.8.0.8? → blocking1.8.0.8-
Group: security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: