Closed
Bug 312804
Opened 19 years ago
Closed 19 years ago
[FIX]No longer shows loading-image.gif when loading images; shows broken-image.gif instead.
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect, P1)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: moz, Assigned: bzbarsky)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Biesinger
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
As of the October 17 builds of both Camino and Firefox, I'm no longer getting
the appropriate loading-image.gif in image frames while the images are loading;
I get broken-image.gif instead. loading-image.gif shows up as it should in the
October 16 Camino trunk build.
Possible bug 288064 fallout?
|
||
Comment 1•19 years ago
|
||
I can confirm that loading-image.gif is used on Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.9a1) Gecko/20051016 Firefox/1.6a1 ID:2005101604 and broken-image.gif
on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051017
Firefox/1.6a1 ID:2005101704...
Hardware & OS -> All?
|
||
Comment 2•19 years ago
|
||
CCing Boris as this may be fall out from his checkin.
|
Assignee | |
Updated•19 years ago
|
Assignee: jdunn → bzbarsky
Priority: -- → P1
Summary: No longer shows loading-image.gif when loading images; shows broken-image.gif instead. → [FIX]No longer shows loading-image.gif when loading images; shows broken-image.gif instead.
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Comment 4•19 years ago
|
||
Basically, loading state is ok when painting, so the ImageOK stuff needs to
deal with that.
Attachment #200010 -
Flags: superreview?(dbaron)
Attachment #200010 -
Flags: review?(cbiesinger)
|
||
Comment 5•19 years ago
|
||
Comment on attachment 200010 [details] [diff] [review]
Patch
r=biesi
Attachment #200010 -
Flags: review?(cbiesinger) → review+
|
||
Comment 6•19 years ago
|
||
Comment on attachment 200010 [details] [diff] [review]
Patch
The macro might make things a little more confusing than needed, but sr=dbaron.
Attachment #200010 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Comment 7•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 8•19 years ago
|
||
Verified FIXED; I see the regular image-loading icon now with build SeaMonkey 1.1a:Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051102 Mozilla/1.0. (That's 2005-11-02-17.)
Status: RESOLVED → VERIFIED
I'm still seeing the "broken-image.gif" while image loading. Firefox Nightly Build 2005110804, 1.5 branch.
|
|
Assignee | |
Comment 10•19 years ago
|
||
This bug was a trunk-only regression from a trunk-only checkin. Whatever you're seeing on the 1.8 branch (which is what I assume you meant), it's not this bug.
|
||
Comment 11•19 years ago
|
||
I see. Thanks for your feedback.
I file a new bug report: 315638.
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
|
||
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•