There is a small area in the tab strip both above (about 5px) and below (about 2px) tabs which responds to a double-click event by opening a new tab. This can lead to unexpected behaviour where new (blank) tabs open and steal UI focus: - user tries to select a tab - user misses and clicks in area above/below tab - user tries a second click, opening a new tab These areas shouldn't respond to the double-click accelerator for creating new tabs.

Quick hack: change (localName != "toolbarbutton") to (localName == "spacer") in onTabBarDblClick. The double click handler really should just be on the spacer.

This is pretty much a dup of bug 218701. I'm not marking it as such because Gavin's fix would fix other bugs (not the same bugs that fixing bug 218701 would fix).

I think you're being too generous - this seems like a full on dupe to me! But I'll take your word for it.

This seems to work, but it makes tabbrowser depend on a certain implementation of tabbox... which I don't think is a good idea.

I'm not sure why we need interchangeable tabbox bindings, really. I'm pretty sure that we make plenty of assumptions about the nature of the tabbox we're using.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/tabs/ http://weblogs.mozillazine.org/ben/archives/009210.html 11/3/05 doesn't even allow for "doubleclick on tab bar=new tab" anymore... but it's not an official build though

Checked in on the trunk. mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.125;

Checked in on the 1.8 branch for Firefox 2. mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.103.2.15;