Closed Bug 313656 Opened 19 years ago Closed 19 years ago

Generated content images don't work the first time

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

()

Details

Attachments

(1 file)

STEPS TO REPRODUCE: Load the testcase. If the image shows up, shift-reload This is also what bites chatzilla's smilies. The problem is that we end up with a state change from LOADING to not LOADING for the generated content, which tries to reframe it... which doesn't really work because it's not real content, so it can't be usefully removed from parent or added to the parent. The two options I see are either reframing the parent or not reframing the generated content here. The latter is simpler for now; the former would be needed to do generated content fallback.
Blocks: 288064
Attached patch Patch (deleted) — Splinter Review
We need both parts, since nsImageLoadingContent just notifies on the ImageState() difference, not the IntrinsicState() difference. Perhaps we should change that...
Attachment #200660 - Flags: superreview?(dbaron)
Attachment #200660 - Flags: review?(cbiesinger)
Comment on attachment 200660 [details] [diff] [review] Patch I guess. I'd prefer it if reframing was fixed to correctly handle this... but if that's too hard, please at least add a comment to these two places explaining why you do this. r=biesi
Attachment #200660 - Flags: review?(cbiesinger) → review+
The real problem is lack of clear idea of what "correctly" is here. I'd rather not change layout in ways that depend on imagelib being sometimes sync, which is what I'd need here if I reframed the parent on LOADING state change.
Attachment #200660 - Flags: superreview?(dbaron) → superreview+
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Flags: in-testsuite?
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: