Closed
Bug 313656
Opened 19 years ago
Closed 19 years ago
Generated content images don't work the first time
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
Biesinger
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: Load the testcase. If the image shows up, shift-reload
This is also what bites chatzilla's smilies. The problem is that we end up with a state change from LOADING to not LOADING for the generated content, which tries to reframe it... which doesn't really work because it's not real content, so it can't be usefully removed from parent or added to the parent.
The two options I see are either reframing the parent or not reframing the generated content here. The latter is simpler for now; the former would be needed to do generated content fallback.
Assignee | ||
Comment 1•19 years ago
|
||
We need both parts, since nsImageLoadingContent just notifies on the ImageState() difference, not the IntrinsicState() difference. Perhaps we should change that...
Attachment #200660 -
Flags: superreview?(dbaron)
Attachment #200660 -
Flags: review?(cbiesinger)
Comment 2•19 years ago
|
||
Comment on attachment 200660 [details] [diff] [review]
Patch
I guess. I'd prefer it if reframing was fixed to correctly handle this... but if that's too hard, please at least add a comment to these two places explaining why you do this.
r=biesi
Attachment #200660 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 3•19 years ago
|
||
The real problem is lack of clear idea of what "correctly" is here. I'd rather not change layout in ways that depend on imagelib being sometimes sync, which is what I'd need here if I reframed the parent on LOADING state change.
Updated•19 years ago
|
Attachment #200660 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 4•19 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite?
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•