Closed Bug 3202 Opened 26 years ago Closed 26 years ago

RX: GTK/nsWindow.h

Categories

(Core :: Widget: Gtk, defect, P2)

x86
Windows 95
defect

Tracking

()

VERIFIED INVALID

People

(Reporter: chofmann, Assigned: pierre)

Details

Much of our non-static/global data needs to be partitioned by window, not reachable by other windows except through statics/globals. Therefore we're starting the hunt with statics and globals. Please have a look at the file(s) below to see if we can improve reentrantcy across the code base by making modifications to: These are probably save, but each owner (ramiro, pierre, michaelp?) needs to have a look (motif is obsolete, should it be cvs removed? Please ask if you can, in the bug): widget/src/gtk/nsWindow.h: char gInstanceClassName[256]; widget/src/mac/nsWindow.h: char gInstanceClassName[256]; widget/src/motif/nsWindow.h: char gInstanceClassName[256];
RX tasks aren't going to make M3. close the reentrantcy tracking tasks if this specific area has been looked at and doesn't seem to be a problem. Otherwise each of these areas still need some looking at.
i just removed this under unix as it wans't being used.
This is not an issue on the Mac: "gInstanceClassName" is a member variable, not a global. I'll leave it there because it's convenient for debugging sometimes.
Assignee: ramiro → pierre
Pavlov yanked this code from the unix gtk widget impl. It wasnt used. Reassign to pierre.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → INVALID
The unix folks removed that code but as I wrote, I prefer to keep it on the Mac because it sometimes makes the debugging easier. Overall, I think that this bug was Invalid because "gInstanceClassName" was a member variable, not a global and thus did not present any RX ("reentrance") problem. Closed as Invalid.
QA: I verified on LXR that "gInstanceClassName" was now only used on the Mac and on Motif (which is obsolete). The URL is: http://lxr.mozilla.org/seamonkey/search?string=gInstanceClassName
Status: RESOLVED → VERIFIED
Verified Invalid
Component: XP Miscellany → Widget: Gtk
You need to log in before you can comment on or make changes to this bug.