Closed Bug 3203 Opened 26 years ago Closed 26 years ago

RX: Mac widgets

Categories

(Core Graveyard :: Widget: Mac, defect, P2)

x86
Windows 95
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: chofmann, Assigned: pierre)

Details

Must be pierre: Much of our non-static/global data needs to be partitioned by window, not reachable by other windows except through statics/globals. Therefore we're starting the hunt with statics and globals. Please have a look at the file(s) below to see if we can improve reentrantcy across the code base by making modifications to: widget/src/mac/nsAppShell.h: static PRBool mInitializedToolbox; widget/src/mac/nsMacMessagePump.h: static nsWindowlessMenuEventHandler gWindowlessMenuEventHandler; widget/src/mac/nsMenu.h: static PRInt16 mMacMenuIDCount; widget/src/mac/nsScrollbar.h: static ControlActionUPP sControlActionProc; // we only need one of these widget/src/mac/nsToolkit.h: static nsWindow* mFocusedWidget; widget/src/mac/nsToolkit.h: static PLEventQueue* sPLEventQueue;
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
These data can't be partitioned by window: we need only one copy per application. All are private/protected: just one wasn't, it's fixed now.
thanks
QA Contact: 3849
pierre -- is this a code level fault? If so, did you did a self test or some other test to verify fix?
Status: RESOLVED → VERIFIED
The bug was opened at the same time as dozens of other ones asking programmers to check for static objects in their modules. We can't do much more, except verify that the modified code (if any) does work. On my part, I just changed a public variable to private and this has no impact on the program execution. Marked Verified.
Component: XP Miscellany → Widget: Mac
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.