Closed
Bug 3208
Opened 26 years ago
Closed 26 years ago
RX: unicharutil case
Categories
(Core :: Internationalization, defect, P2)
Tracking
()
VERIFIED
INVALID
M4
People
(Reporter: chofmann, Assigned: ftang)
Details
Guessing: ftang, cata, erik:
Much of our non-static/global data needs to be partitioned by window,
not reachable by other windows except through statics/globals.
Therefore we're starting the hunt with statics and globals.
Please have a look at the file(s) below to see if we can improve reentrantcy
across
the code base by making modifications to:
intl/unicharutil/src/casetable.h:static PRUnichar gUpperToTitle[] = {
intl/unicharutil/src/casetable.h:static PRUint32 gUpperToTitleItems = 4;
intl/unicharutil/src/casetable.h:static PRUint16 gToUpper[] =
intl/unicharutil/src/casetable.h:static PRUint32 gToUpperItems = 103;
intl/unicharutil/src/casetable.h:static PRUint16 gToLower[] =
intl/unicharutil/src/casetable.h:static PRUint32 gToLowerItems = 96;
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx1[224] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx2[288] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx3[320] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx4[128] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx5[224] = {
intl/unicharutil/src/cattable.h:static PRUint32 gGenCatPat[201] = {
intl/unicharutil/src/nsCaseConversionImp.h: static PRBool gInit;
intl/unicharutil/src/nsCaseConversionImp2.h: static PRBool gInit;
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•26 years ago
|
||
The following code are READONLY table and these .h file are tool generated,
module private header file which will only be inclued by one single cpp file.
These should be thread safe, reentranctable.
intl/unicharutil/src/casetable.h:static PRUnichar gUpperToTitle[] = {
intl/unicharutil/src/casetable.h:static PRUint32 gUpperToTitleItems = 4;
intl/unicharutil/src/casetable.h:static PRUint16 gToUpper[] =
intl/unicharutil/src/casetable.h:static PRUint32 gToUpperItems = 103;
intl/unicharutil/src/casetable.h:static PRUint16 gToLower[] =
intl/unicharutil/src/casetable.h:static PRUint32 gToLowerItems = 96;
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx1[224] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx2[288] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx3[320] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx4[128] = {
intl/unicharutil/src/cattable.h:static PRUint8 gGenCatIdx5[224] = {
intl/unicharutil/src/cattable.h:static PRUint32 gGenCatPat[201] = {
The following file are obsoleted:
intl/unicharutil/src/nsCaseConversionImp.h: static PRBool gInit;
This is a module private file, I can move this variable inside our cpp file.
intl/unicharutil/src/nsCaseConversionImp2.h: static PRBool gInit;
Reporter | ||
Comment 2•26 years ago
|
||
RX tasks aren't going to make M3.
close the reentrantcy tracking tasks if this specific area has been looked at
and doesn't seem to be a problem. Otherwise each of these areas
still need some looking at.
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → INVALID
Assignee | ||
Comment 3•26 years ago
|
||
Not a problem
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 4•26 years ago
|
||
Verified Invalid
You need to log in
before you can comment on or make changes to this bug.
Description
•