Closed
Bug 321799
Opened 19 years ago
Closed 18 years ago
Incorrect behaviour dynamically switching CSS property 'direction' from 'ltr' to 'rtl' and vice versa
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: vallo_alpino, Assigned: dbaron)
References
()
Details
(Keywords: regression, rtl, testcase)
Attachments
(2 files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.8) Gecko/20051111 Firefox/1.5
Dynamically switching by JavaScript the CSS property ' direction' of a containing box from 'ltr' to 'rtl' and vice versa does not affect the position of the image contained in the box. The containing box (<div></div> tag)has the following CSS properties: {position: absolute; overflow: auto; direction: ltr;...}.
The problem has been detected with the italian version 1.5 and was not present in the previous 1.0.7
See explanatory example at http://valloalpino.altervista.org/bunker/mncs/rvs/rvs5-000.htm
See steps to reproduce for details.
Reproducible: Always
Steps to Reproduce:
1. Go to web page (see above)
2. Click on the right or left grey arrows that appears alternately beside the caption under the map.
3.
Actual Results:
The grey arrows swap but the map doesn't move.
Expected Results:
The grey arrows swap and the map moves inside the windows showing its right or left side.
The web page is compliant with XHTML 1.0 Transitional and works properly with the following browsers:
FF 1.0.7 (Win XP and Linux)
IE 6.0.x (Win XP)
NN 8.0.4 based on Firefox (Win XP)
Opera 8.5 (Win XP and Mac)
Safari (Mac)
The only incorrect behaviour presently known is wit FF 1.5
The web page has been tested by different persons and different systems. See discussion at http://forum.mozillaitalia.org/index.php?topic=15734.0
Comment 1•19 years ago
|
||
*** Bug 321801 has been marked as a duplicate of this bug. ***
Comment 2•19 years ago
|
||
This changed between 1.8b2_2005042806 and 1.8b2_2005042906.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-28+05%3A00%3A00&maxdate=2005-04-29+06%3A00%3A00&cvsroot=%2Fcvsroot
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•19 years ago
|
||
Smaller example:
http://www.thomasoandrews.com/examples/mozilla/321799/
Click on the 'Right' link and it should scroll to the right in the div. Then 'Left' should bring you back.
Reporter | ||
Comment 4•19 years ago
|
||
(In reply to comment #3)
> Smaller example:
>
> http://www.thomasoandrews.com/examples/mozilla/321799/
>
> Click on the 'Right' link and it should scroll to the right in the div. Then
> 'Left' should bring you back.
>
There is a small difference between the smaller example and the original one: in the smaller it scrolls only by the thickness of the vertical scrollbar, whilst in the original, without vertical scrollbar, it doesn't scroll at all. In both examples the image should move completely to the right and then back to the left.
Other difference: the smaller example does not work with IE 6.0, whilst the original does.
Comment 5•19 years ago
|
||
Yes, I was trying to create an example which worked in older Firefox versions but didn't work in the latest release.
Specifically, in simplifying the code, I deliberately removed a lot of cross-browser code to make it easier to debug.
Comment 6•19 years ago
|
||
Okay, I got my example to work in IE.
I'm not sure about your first complaint about my example. I see there is a vertical scrollbar added to the map <div> on Windows, which Firefox does not add on the Mac for some reason. When you click 'Left' or 'Right' it does move that scrollbar to the other side, but it is obviously not doing the correct thing with the change.
Reporter | ||
Comment 7•19 years ago
|
||
(In reply to comment #6)
> Okay, I got my example to work in IE.
>
> I'm not sure about your first complaint about my example. I see there is a
> vertical scrollbar added to the map <div> on Windows, which Firefox does not
> add on the Mac for some reason. When you click 'Left' or 'Right' it does move
> that scrollbar to the other side, but it is obviously not doing the correct
> thing with the change.
>
Ok, now the behaviour is exactly the same of the original page.
Many thanks for your time.
Comment 8•19 years ago
|
||
It's generally not a good idea to confirm bugs like these without putting them in the right component, and even then, leaving as UNCO is probably best (especially for layout bugs).
Component: General → Layout
Product: Firefox → Core
QA Contact: general → layout
Version: unspecified → 1.8 Branch
Comment 9•19 years ago
|
||
Updated•19 years ago
|
Blocks: 240276
Keywords: regression,
testcase
Comment 10•19 years ago
|
||
(In reply to comment #8)
Yes, I knew. Must have put a tick in the wrong box.
Comment 11•19 years ago
|
||
roc, this looks like some sort of reflow over-optimization fallout from bug 240276 to me...
Flags: blocking1.9a1?
Flags: blocking1.8.1?
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
Assignee | ||
Comment 12•18 years ago
|
||
FWIW, this is fixed on the trunk but not on the branch. It would be useful to figure out what fixed it on the trunk.
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → dbaron
Comment 13•18 years ago
|
||
Assignee | ||
Comment 14•18 years ago
|
||
Probably bug 192767, then. That's too big to consider for the branch, but we might be able to figure out a small piece of it that would fix this.
Updated•18 years ago
|
Target Milestone: --- → mozilla1.8.1beta2
Assignee | ||
Comment 15•18 years ago
|
||
Actually, now that I look at the testcase more closely, it seems more like bug 318116, which we were not fixing intentionally until bug 192767 was fixed. So I'm surprised that this is reported as a regression.
Assignee | ||
Comment 16•18 years ago
|
||
Presumably the fix means it now scrolls to the right for a different reason than it did before the regression.
Assignee | ||
Comment 17•18 years ago
|
||
Assignee | ||
Updated•18 years ago
|
Attachment #227747 -
Attachment mime type: text/h → text/html; charset=UTF-8
Assignee | ||
Comment 18•18 years ago
|
||
I think the pre-regression behavior is worse than the post-regression behavior, since the behavior with a single large image in the middle of a large chunk of text is really quite bad -- the user might be unaware that there's any text to scroll to.
I don't think we should fix this without taking bug 192767, bug 96394, bug 318116, and all regression fixes from those bugs. I'm not sure how much that scares people at this point. (I think there are still some unfixed regressions from those, although they're pretty minor, IIRC.)
Comment 19•18 years ago
|
||
(In reply to comment #18)
> I don't think we should fix this without taking bug 192767, bug 96394, bug
> 318116, and all regression fixes from those bugs. I'm not sure how much that
> scares people at this point. (I think there are still some unfixed regressions
> from those, although they're pretty minor, IIRC.)
>
Fixing those bugs on the branch will make bidi users very happy (for reasons other than this bug). I've been using trunk builds regularly, and other than the very minor regressions mentioned, I'm not seeing any problems. Still, 192767 was a big patch... so some people might be scared.
Assignee | ||
Comment 20•18 years ago
|
||
Minusing for blocking1.8.1 given that we shipped 1.8 with this and it's really a pretty obscure misuse of 'direction'. It's already fixed on the trunk.
We probably should have considered taking the bugs that fixed this a few months ago for 1.8.1 on their own merits, but I think it's probably a bit late to do that now.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: blocking1.9a1?
Flags: blocking1.8.1-
Flags: blocking1.8.1+
Resolution: --- → FIXED
Comment 21•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•