Closed
Bug 3219
Opened 26 years ago
Closed 26 years ago
RX: nsRepeater.h
Categories
(Core Graveyard :: Widget: Mac, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
M3
People
(Reporter: chofmann, Assigned: mozeditor)
Details
Both of sfraser and jfrancis, from the CVS log:
Much of our non-static/global data needs to be partitioned by window,
not reachable by other windows except through statics/globals.
Therefore we're starting the hunt with statics and globals.
Please have a look at the file(s) below to see if we can improve reentrantcy
across
the code base by making modifications to:
base/public/nsRepeater.h: static Repeater* sRepeaters;
base/public/nsRepeater.h: static Repeater* sIdlers;
Updated•26 years ago
|
Assignee: sfraser → jfrancis
Comment 1•26 years ago
|
||
nsReater is Joe's baby
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
OS: Windows 95 → Mac System 8.5
Hardware: PC → Macintosh
Resolution: --- → FIXED
Assignee | ||
Comment 2•26 years ago
|
||
This is pretty much a non-issue. We do need a static here (you do on windows
too, only its hidden in the os there). We could put locks the list access, but
it doesn't matter until there is a preemptive macos.
Updated•26 years ago
|
QA Contact: 3849
Comment 3•26 years ago
|
||
Joe -- so how is this fixed? How can I verify this or can you verify this?
Assignee | ||
Comment 4•26 years ago
|
||
It isn't "fixed". Rather, it was never a bug. The statics in question are not
in XP code, but in mac-only code. As I understand it, chofmann's original bug
report was a request to check these statics and verify that they do not pose a
reentrancy hazzard.
I've checked and they don't.
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 5•26 years ago
|
||
cool -- marking verified per developer comment
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67bfee9cfe3f
servo: Merge #4702 - Bug #3219 - Assign hostfile using the HOST_FILE environment variable (from shinglyu:bug3219); r=jdm
You need to log in
before you can comment on or make changes to this bug.
Description
•