Closed Bug 326329 Opened 19 years ago Closed 19 years ago

remove user interface for DPI preference

Categories

(Core Graveyard :: GFX, defect, P1)

Product:
Core Graveyard
Component:
GFX
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: fixed1.8.1, Whiteboard: [patch])

Attachments

(3 files, 2 obsolete files)

patch to remove common toolkit code for Ruler UI
(deleted), patch
mconnor
: review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review
patch to remove UI from thunderbird
(deleted), patch
mscott
: review+
mscott
: approval-branch-1.8.1+
Details | Diff | Splinter Review
patch to remove UI from SeaMonkey
(deleted), patch
neil
: approval-branch-1.8.1+
Details | Diff | Splinter Review
We should remove the user interface for the DPI preference. The reasons to do this are given in bug 323962 comment 3, where I removed part of it for Firefox.
Not yet tested.
Not yet tested.
Attached patch patch to remove UI from SeaMonkey (obsolete) (deleted) — — Splinter Review
Not yet tested.
Status: NEW → ASSIGNED
Flags: blocking1.9a1?
Flags: blocking1.8.1?
Priority: -- → P1
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8.1
Comment on attachment 211077 [details] [diff] [review] patch to remove UI from thunderbird Tested this in Thunderbird; it works fine. It could probably be compacted a little for me, but probably not for other languages or if the dialog width varies.
Attachment #211077 - Flags: review?(mscott)
Attachment #211077 - Flags: branch-1.8.1?(mscott)
Attachment #211076 - Flags: review?(mconnor)
Attachment #211076 - Flags: branch-1.8.1?(mconnor)
Comment on attachment 211077 [details] [diff] [review] patch to remove UI from thunderbird thanks david.
Attachment #211077 - Flags: review?(mscott)
Attachment #211077 - Flags: review+
Attachment #211077 - Flags: branch-1.8.1?(mscott)
Attachment #211077 - Flags: branch-1.8.1+
Blocks: 326175
Comment on attachment 211078 [details] [diff] [review] patch to remove UI from SeaMonkey /xpfe/components/prefwindow/resources/locale/en-US/pref-fonts.dtd will need to have relevant entities removed.
Comment on attachment 211077 [details] [diff] [review] patch to remove UI from thunderbird Checked in to trunk.
Attached patch patch to remove UI from SeaMonkey (obsolete) (deleted) — — Splinter Review
Attachment #211078 - Attachment is obsolete: true
Attachment #211311 - Flags: superreview?(jag)
Attachment #211311 - Flags: review?(timeless)
Attachment #211311 - Flags: superreview?(jag) → superreview+
Depends on: 327406
Attachment #211076 - Flags: review?(mconnor)
Attachment #211076 - Flags: review+
Attachment #211076 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #211076 - Flags: approval-branch-1.8.1+
Attachment #211311 - Flags: review?(timeless) → review?(neil)
Comment on attachment 211076 [details] [diff] [review] patch to remove common toolkit code for Ruler UI Checked in to trunk.
Comment on attachment 211311 [details] [diff] [review] patch to remove UI from SeaMonkey >-<!-- font scaling --> >-<!ENTITY resolution.label "Display resolution:"> >-<!ENTITY resolution.accesskey "r"> >-<!-- LOCALIZATION NOTE (resolution.dpi): dpi stands for "dots per inch" --> >-<!ENTITY resolution.dpi "dpi"> >-<!-- LOCALIZATION NOTE (resolution.dpi): $val will be replaced by a numeric dpi value. --> >-<!ENTITY resolution.dpival "$val &resolution.dpi;"> >-<!ENTITY resolution.system.label "System setting"> >-<!ENTITY resolution.other "Other..."> >- > <!-- screen calibration dialog --> > <!ENTITY calibrateDialog.title "Calibrate Resolution"> > <!ENTITY calibrate.instructions "The length of the line above is:"> > <!ENTITY units.inches "inches"> > <!ENTITY units.centimetres "centimeters"> These entities can go too, right?
Attachment #211311 - Flags: review?(neil) → review+
(In reply to comment #10) > These entities can go too, right? Yep.
Attachment #211311 - Attachment is obsolete: true
Comment on attachment 213234 [details] [diff] [review] patch to remove UI from SeaMonkey Checked in to trunk.
Attachment #213234 - Flags: approval-branch-1.8.1?(neil)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #213234 - Flags: approval-branch-1.8.1?(neil) → approval-branch-1.8.1+
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Blocks: 330171
Flags: blocking1.9a1?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: