Closed
Bug 328956
Opened 19 years ago
Closed 19 years ago
chop dead wood off of toolkit
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
References
()
Details
(Keywords: fixed1.8.1, Whiteboard: url consolidation)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bugs
:
review+
|
Details | Diff | Splinter Review |
There are an awful lot of left overs in toolkit which put work load on localizers
without being used anywhere.
Look at the links at the wiki, prominent examples are wallet urls, svg.properties,
getNewThemesURL (that's xpfe only), the 1.0.x defines for app.update.url, and
maybe more, I'm still investigating.
Assignee | ||
Comment 1•19 years ago
|
||
I filed bug 328988 on removal of builtinURLs.rdf, as that involves more work than
just removal of dead wood.
Whiteboard: url consolidation
Assignee | ||
Comment 2•19 years ago
|
||
This patch removes:
svg.properties (dead, according to tor)
wallet.foo from intl.properties, those entities aren't used in wallet
(the mail navigator.properties was already removed)
getNewThemesURL and content.version from region.dtd (xpfe only)
releaseURL from region.dtd, unused
getNewThemesURL and smartBrowsingURL from region.properties (xpfe only)
update.properties copy from update, this one is in extensions now (which
doesn't need app.update.url anymore), the one in update ain't even built.
These removals have been backed up by lxr searches on the 1.8 branch.
I need a real review from Ben to make sure these are really dead.
I have approval from KaiRo to chop out the xpfe-only things, whatever they
would want to add back for seamonkey-on-toolkit will go in their application
locale.
The remaining URLs in the code still need to be consolidated, too.
Attachment #213731 -
Flags: review?(beng)
Assignee | ||
Updated•19 years ago
|
Attachment #213731 -
Attachment is obsolete: true
Attachment #213731 -
Flags: review?(beng)
Assignee | ||
Comment 3•19 years ago
|
||
I forgot to remove svg.properties from jar.mn.
Attachment #216342 -
Flags: review?
Assignee | ||
Updated•19 years ago
|
Attachment #216342 -
Flags: review? → review?(beng)
Assignee | ||
Updated•19 years ago
|
Attachment #216342 -
Flags: review?(beng) → review?(bugs)
Comment 4•19 years ago
|
||
Attachment #216342 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•19 years ago
|
||
Landed on both trunk and 1.8 branch. This turned locales orangeon both those
branches.
You need to log in
before you can comment on or make changes to this bug.
Description
•