Closed Bug 328956 Opened 19 years ago Closed 19 years ago

chop dead wood off of toolkit

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

()

Details

(Keywords: fixed1.8.1, Whiteboard: url consolidation)

Attachments

(1 file, 1 obsolete file)

There are an awful lot of left overs in toolkit which put work load on localizers without being used anywhere. Look at the links at the wiki, prominent examples are wallet urls, svg.properties, getNewThemesURL (that's xpfe only), the 1.0.x defines for app.update.url, and maybe more, I'm still investigating.
I filed bug 328988 on removal of builtinURLs.rdf, as that involves more work than just removal of dead wood.
Whiteboard: url consolidation
Attached patch remove dead code (obsolete) (deleted) — Splinter Review
This patch removes: svg.properties (dead, according to tor) wallet.foo from intl.properties, those entities aren't used in wallet (the mail navigator.properties was already removed) getNewThemesURL and content.version from region.dtd (xpfe only) releaseURL from region.dtd, unused getNewThemesURL and smartBrowsingURL from region.properties (xpfe only) update.properties copy from update, this one is in extensions now (which doesn't need app.update.url anymore), the one in update ain't even built. These removals have been backed up by lxr searches on the 1.8 branch. I need a real review from Ben to make sure these are really dead. I have approval from KaiRo to chop out the xpfe-only things, whatever they would want to add back for seamonkey-on-toolkit will go in their application locale. The remaining URLs in the code still need to be consolidated, too.
Attachment #213731 - Flags: review?(beng)
Attachment #213731 - Attachment is obsolete: true
Attachment #213731 - Flags: review?(beng)
Attached patch forgot one line in jar.mn (deleted) — Splinter Review
I forgot to remove svg.properties from jar.mn.
Attachment #216342 - Flags: review?
Attachment #216342 - Flags: review? → review?(beng)
Attachment #216342 - Flags: review?(beng) → review?(bugs)
Comment on attachment 216342 [details] [diff] [review] forgot one line in jar.mn r=ben@mozilla.org
Attachment #216342 - Flags: review?(bugs) → review+
Landed on both trunk and 1.8 branch. This turned locales orangeon both those branches.
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Blocks: 335739
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: