Closed
Bug 331530
Opened 19 years ago
Closed 17 years ago
background painting and scrollbar code should use nsHTMLDocument::GetBody directly
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: perf, Whiteboard: [patch])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
sicking
:
review+
sicking
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Sicking points out that nsHTMLDocument::GetBody can be slow; we should expose GetBodyContent and use it in the places where background painting and scrollframes care about the <body> only (not framesets!).
|
Assignee | |
Comment 1•19 years ago
|
||
Untested patch (no longer applies to trunk due to sicking's backout).
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Updated•19 years ago
|
Attachment #216069 -
Flags: superreview?(jst)
Attachment #216069 -
Flags: review?(bugmail)
Attachment #216069 -
Flags: review?(bugmail) → review+
|
||
Comment 2•19 years ago
|
||
Comment on attachment 216069 [details] [diff] [review]
untested patch
sr=jst
Attachment #216069 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Updated•18 years ago
|
QA Contact: ian → style-system
Depends on: 366200
|
|
Assignee | |
Comment 3•17 years ago
|
||
Fixing bug 379461 reminded me of this patch that I had in my tree, so I updated it. I chose to name the new function GetBodyContentExternal this time, since it led to a smaller patch and it reduces the risk of future callers accidentally caling the slow virtual function when they could avoid it.
Attachment #216069 -
Attachment is obsolete: true
Attachment #303678 -
Flags: superreview?(jonas)
Attachment #303678 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #303678 -
Flags: superreview?(jonas)
Attachment #303678 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 4•17 years ago
|
||
This one actually works, now that I found I needed to manually modify htmldocument.gqi (UGH! filed bug 417892).
Attachment #303678 -
Attachment is obsolete: true
Attachment #303684 -
Flags: superreview?(jonas)
Attachment #303684 -
Flags: review?(jonas)
Attachment #303684 -
Flags: superreview?(jonas)
Attachment #303684 -
Flags: superreview+
Attachment #303684 -
Flags: review?(jonas)
Attachment #303684 -
Flags: review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Comment on attachment 303684 [details] [diff] [review]
patch
Simple performance patch (low risk) that I've had lying around for a long time.
Attachment #303684 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #303684 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Checked in 2008-02-19 08:48 -0800, mostly backed out 2008-02-19 09:28 -0800 since I needed to back out bug 379461 (which this applied on top of) due to reftest failures, and relanded 2008-02-19 10:47 -0800.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9alpha1 → mozilla1.9beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•