Closed
Bug 336887
Opened 19 years ago
Closed 19 years ago
search bar Go button is way too wide, when toolbar icons are set to "Icons & Text" or "Text"
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha3
People
(Reporter: RyanVM, Assigned: martijn.martijn)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060506 Firefox/3.0a1
The magnifying glass Go button for the search bar is nearly half the width of the entire field. It actually truncates "Google Search" it's so large. It needs a shrinking.
I'm using the default Winstripe theme.
Reporter | ||
Comment 1•19 years ago
|
||
Here's a screenshot
Comment 2•19 years ago
|
||
WFM
http://img320.imageshack.us/img320/6092/search1zq.jpg
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060506 Minefield/3.0a1, Firefox ID:2006050604 [cairo]
Comment 3•19 years ago
|
||
My capture did not copy right...
The search box and new go/drop arrow are normal here and I see all the text.
Correct image: http://img428.imageshack.us/img428/7716/srch3bu.jpg
Reporter | ||
Comment 4•19 years ago
|
||
In safe mode, it looks OK to me as well. However, if I just manually disable all of my extensions and restart, it is still wide like the screenshot I posted.
Also, in the "Customize Toolbar" window, it appears properly. It's only when it's actually on the toolbar that it's broken.
Gavin, any idea as to what's going on?
Comment 6•19 years ago
|
||
Looks like it is intended here, but why not reverting to the previous behaviour and then including Pike's Search Button?
http://www.pikey.me.uk/mozilla/?extension=sb
Assignee | ||
Comment 7•19 years ago
|
||
I have the same issue, I don't have anything relevant in my userChrome.css.
With the dom inspector, it seems like this rule is responsible for it:
http://lxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/browser.css#221
When I remove that css rule, the ridiculous width is gone.
The weird icon is coming from this:
http://lxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/searchbar.css#26
Removing that doesn't help, because I don't have an search icon at all after that.
Assignee | ||
Comment 8•19 years ago
|
||
Oops! Apparently, the weird icon is intended.
Comment 9•19 years ago
|
||
*** Bug 337045 has been marked as a duplicate of this bug. ***
Comment 10•19 years ago
|
||
As Stated in My Bug, It's when Toolbar Buttons are set to show both icons and text that this bug happens.
Comment 11•19 years ago
|
||
CC'ing Pam Greene creator of the original patch that introduce this feature
Assignee | ||
Comment 12•19 years ago
|
||
This fixes the bug. I don't see any regressions from this, so it seems it can safely be removed.
Attachment #221236 -
Flags: review?(pamg.bugs)
Updated•19 years ago
|
Summary: Search bar Go icon is way too wide → search bar Go button is way too wide, when toolbar icons are set to "Icons & Text" or "Text"
Comment 13•19 years ago
|
||
Comment on attachment 221236 [details] [diff] [review]
patch
Martijn, if you can land this ASAP that'd be great, if not please let me know by email.
Attachment #221236 -
Flags: review?(pamg.bugs)
Attachment #221236 -
Flags: review+
Attachment #221236 -
Flags: approval-branch-1.8.1+
Assignee | ||
Comment 14•19 years ago
|
||
I can check this in about 5 hours or so.
For future reference, if you need some patch by me to get checked in, you may check it in, I don't mind.
Updated•19 years ago
|
Assignee: nobody → martijn.martijn
Target Milestone: --- → Firefox 2 alpha3
Updated•19 years ago
|
Whiteboard: [checkin needed]
Comment 15•19 years ago
|
||
Checked in, branch and trunk.
mozilla/browser/themes/winstripe/browser/browser.css 1.35
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.21
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Version: Trunk → 2.0 Branch
Comment 16•19 years ago
|
||
uh, for me, it seems when icons are set to text it still shows only the arrow
Comment 17•19 years ago
|
||
oh, didn't see the other bug. sorry for the bugspam >.>
You need to log in
before you can comment on or make changes to this bug.
Description
•