Closed Bug 33723 Opened 25 years ago Closed 23 years ago

Need to display empty menus differently (currently display as tiny boxes)

Categories

(Core :: XUL, defect, P3)

x86
All
defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: gerv, Assigned: mikepinkerton)

References

Details

(Keywords: polish)

From Bugzilla Helper: User-Agent: Mozilla/4.7 [en] (Win95; U) BuildID: 20000328 In the Bookmarks menu on the menu bar, under the current skin, empty folders and bookmarks look the same - just the title. NS 4.x gets around this by using icons on menus (and also by not displaying empty folders in the menus at all, but that could be a bug in NS 4.x). This is rather confusing. I would suggest either adding icons to this menu, not adding empty folders to it at all, or adding them but giving them a Right Arrow which expands to a single-entry menu saying "(Empty)".
Moving my own bug to UI:DF for further consideration :-) Gerv
Assignee: slamm → bdonohoe
Component: Bookmarks → User Interface: Design Feedback
QA Contact: claudius → mpt
the icons are there now so I assume this bug is just to evaluate the suggestion to add the <empty> to submenus for empty folders? I think it's a good idea </.02¢>
While the Bookmarks window is still open, when a new folder is created it has a 1-pixel-by-1-pixel menu when clicked in the Bookmarks Toolbar. Isn't that enough? :-) (The minimal menu is just a symptom of a more general bug -- does anyone want to file `Menus with zero items still appear', and CC me on it?) Empty folders should probably still appear in the toolbar, otherwise there will be problems of the contents of the toolbar appearing not to match the bookmarks file itself. And of course I might create an empty folder on the toolbar for the express purpose of dragging links into it later. Perhaps a better solution would be to do the `[Empty]' thing, like Windows does with empty folders in the Start menu.
URL: None
This bug is no longer a problem as originally stated, since the personal toolbar bookmarks now look different, and have different icons for bookmarks and folders. We could either close it, or convert it to a RFE for "Empty" (which I think isn't necessary, as the folders animate on opening, which is enough of a visual clue). Gerv
An <EMPTY> menu would be nice, making it very clear what's going. The icon animation is good, too, but very subtle. However, any enhancement here is very low priority. Marking RFE, M18, and reassigning to XP Toolkit/Menus.
Assignee: bdonohoe → pinkerton
Severity: normal → enhancement
Component: User Interface: Design Feedback → XP Toolkit/Widgets: Menus
QA Contact: mpt → sairuh
Target Milestone: --- → M18
mass-moving all bugs to m21 that are not dofood+, or nsbeta2+
Target Milestone: M18 → M21
Rewriting title to reflect new status of bug. Gerv
Summary: Empty folders and bookmarks identical in Bookmarks menu → RFE: "Empty" indication for empty folders in Bookmarks menu
*spam*: transferring current XP Menu bugs over to jrgm, the new component owner. feel free to add me to the cc list (unless am the Reporter) of any of these, if you have any questions/etc.
QA Contact: sairuh → jrgm
*** Bug 41621 has been marked as a duplicate of this bug. ***
This behavior is showing up in more places than just sub-menus, including the URL drop-down which doesn't have the benefit of an animated folder icon. I recommend raising the priority of putting an '<empty>' string into empty menus. This will not only improve usability for the general public, it'll make the product look more professional and polished (the 1x1 square that currently appears looks like an oversight).
*** Bug 41621 has been marked as a duplicate of this bug. ***
For the URL drop-down, `(No previous addresses)' (or even nothing at all) would make more sense than `(Empty)' would. Could menus be given some way of specifying their empty text?
Target Milestone: M21 → Future
*** Bug 49730 has been marked as a duplicate of this bug. ***
Severity: enhancement → normal
Keywords: polish
Summary: RFE: "Empty" indication for empty folders in Bookmarks menu → Need to display empty menus differently (currently display as tiny boxes)
Status: NEW → ASSIGNED
*** Bug 67591 has been marked as a duplicate of this bug. ***
*** Bug 67591 has been marked as a duplicate of this bug. ***
Nominating for 0.9
Keywords: mozilla0.9
*** Bug 68428 has been marked as a duplicate of this bug. ***
This is now a 5x5 square, but it's still not ideal. Menus should be able to specify their empty text, definitely. It should be shown greyed out by default. Gerv
Keywords: 4xp
These little empty menu boxes bug me. Can we do this in two steps? The first would be to add a disabled menu item that reads "(Empty)", just like Windows does. The second would be an RFE to make that text string customizable by the menu itself.
*** Bug 85035 has been marked as a duplicate of this bug. ***
Keywords: mozilla0.9.3
A possible problem with this is that it's difficult to tell if the menu is really empty - content and RDF can both update them dynamically - IIRC the content update can alter the effect of the RDF update so there isn't a late enough event to catch. Or is there?
This works nicely now, except that neil's comment on a problem became true (at least as of 0.9.3); If you drag a bookmark to a folder that is emtpy; you then get two items, one of which is the empty item. It stays until restart AFAICT. Didn't see this bug anywhere else after a short search.
Jim, that's bug 79411. Marking fixed (or should that be worksforme?... whatever) based on: - Jim's comments - that I now get an "(Empty)" item in the bookmarks menu when I create an empty bookmarks folder - I get a "(Nothing Available)" entry when I clear the Location Bar and then display the drop-down.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 103895 has been marked as a duplicate of this bug. ***
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.