Rob Strong has implemented an NSIS installer in toolkit which is now used by Firefox. This bug is to track the Thunderbird specific work to leverage the new installer. See Bug 326580 for information about the Firefox changes.

Also see bug 339061 for tracking other work being done on the NSIS installer.

This gets us most of the way there. I still have some work to do with registering the mapi dll, and some other stuff.

Here's an updated patch based on the l10n changes Rob landed last night. Still to do: 1) Remove the Mail and News registry keys when uninstalling, if we are the current thunderbird installation. 2) The old installer was doing some mapi dll copying and registration. I need to re-remember what it was trying to do, and add that code.

Comment on attachment 226718 [details] [diff] [review] updated patch based on the recent l10n changes We can get the review process started on this while the Tinderbox machines get updated with nsis.

Comment on attachment 226718 [details] [diff] [review] updated patch based on the recent l10n changes >Index: other-licenses/branding/thunderbird/Makefile.in ... >@@ -53,6 +53,8 @@ > cp $(srcdir)/thunderbird.ico $(DIST)/branding/app.ico > cp $(srcdir)/Header.bmp $(DIST)/branding/Header.bmp > cp $(srcdir)/Watermrk.bmp $(DIST)/branding/Watermrk.bmp >+ cp $(srcdir)/wizWatermark.bmp $(DIST)/branding/wizWatermark.bmp >+ cp $(srcdir)/wizHeader.bmp $(DIST)/branding/wizHeader.bmp Needs wizHeaderRTL.bmp here and in the non-official branding Makefile.in along the lines of. + cp $(srcdir)/wizHeader.bmp $(DIST)/branding/wizHeader.bmp + cp $(srcdir)/wizHeaderRTL.bmp $(DIST)/branding/wizHeaderRTL.bmp + cp $(srcdir)/wizWatermark.bmp $(DIST)/branding/wizWatermark.bmp >Index: mail/installer/Makefile.in ... >+MOZ_OPTIONAL_PKG_LIST = \ >+ talkback \ >+ $(NULL) just so you know, the Firefox installer will not show the optional components page during a custom install if talkback is the only optional component or it is not present. This page also has accessibility issues so this is a good thing. >Index: mail/installer/windows/Makefile.in ... >@@ -49,6 +49,9 @@ > OBJ_DIR=$(shell cygpath -a $(DEPTH)) > SRC_DIR=$(shell cygpath -a $(topsrcdir)) > >+CONFIG_DIR := $(shell pwd)/instgen >+SFX_MODULE = $(topsrcdir)/other-licenses/7zstub/thunderbird/7zSD.sfx >+ Some major changes are happening to this file to support locale repackaging which need to be changed for Thunderbird as well so I'm going to skip review on this file. See bug 227315. >Index: mail/installer/windows/nsis/SetProgramAccess.nsi ... >+Function un.SetAccess >+ Call un.GetParameters >+ Pop $R0 >+ >+ StrCpy $R1 "Software\Clients\Mail\${BrandFullName}\InstallInfo" I haven't verified if software update changes this key name or not... it does on other registry keys and it may end up getting changed out from under this code. This doesn't affect browsers since they use the exe name which causes other issues. >Index: mail/installer/windows/nsis/defines.nsi.in ... >+!define BrandShortName "Thunderbird" >+!define BrandFullName "Mozilla Thunderbird" >+!define FileMainEXE "thunderbird.exe" >+!define CompanyName "Mozilla" >+!define URLInfoAbout "http://www.mozilla.org/" >+!define URLUpdateInfo "http://www.mozilla.org/products/thunderbird/" >+!define WindowClass "ThunderbirdMessageWindow" >+!define SurveyURL "https://survey.mozilla.com/1/Mozilla%20Thunderbird/${AppVersion}%20(${AB_CD})/exit.html" The survey will be changing per Bug 340629 >+# !define 7ZipSFXModule "other-licenses/7zstub/thunderbird/7zSD.sfx" The 7ZipSFXModule define can be removed >+ >+# Percentage of new "Standard" installs to enable talkback for >+# Change me for release builds! >+!define RandomPercent "75" This is at 75 to test if this is working properly and we are probably going to change that to 100 on the trunk and branch and 10 for official releases. I'm not sure what you want for Thunderbird here. I will be submitting a patch soon that will put a subset of this file in the official branding directory so it will automatically use the correct values for official releases without having to change the file itself. Pretty much everything else has changed to support l10n and will need to be significantly updated... I think I owe you a lunch for that. Sorry.

The locale repackaging bug is actually bug 339714.

It helps if I actually attach the correct patch :) This patch doesn't have the RTL image in it yet though.

I'm going to verify this has everything needed before requesting review.

Rob, I just tested your updated patch with a trunk, unofficial build. The artwork looked correct and the installer appeared to be working correctly. 1) The registry keys were correctly written for Mail and News. 2) Both the standard and the custom install options finished successfully. 3) Basic uninstall worked. The program was removed from the program access list, and the files were removed. 4) After uninstalling, the launch survey feature worked as expected. One issue, during the installation, I wasn't seeing the text go by for progress information such as "Cleaning Up the birdcage", Installing Language Files, etc. I wasn't seeing any of those progress strings flash by.

Comment on attachment 229176 [details] [diff] [review] patch for review Thanks Rob!

I went ahead and checked in all of the new files and this just contains the makefile changes required to build the NSIS installer which should land after patrocles has NSIS installed in bug 342370.

Why are there the old bitmaps - not the official branding in MOZILLA_1.8_BRANCH ?

There are both old (unofficial branding) and new (official branding) images. See bug 339747

This has now landed on the trunk and the branch. I filed Bug 345084 to track the one known regression I've run into so far.