Closed Bug 340420 Opened 18 years ago Closed 18 years ago

Support Google "Did you mean..." spelling suggestions in FF2 searchbar

Categories

(Firefox :: Search, enhancement)

2.0 Branch
enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 2 beta1

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Google's suggestion servers return spelling suggestions with embedded HTML formatting, so in order to support this we'd need to add some code to strip HTML tags from suggestion results.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Attached patch Just adds regex replace to strip out HTML tags. (obsolete) (deleted) — Splinter Review
Flags: blocking-firefox2? → blocking-firefox2+
Attachment #224456 - Attachment description: Work in progress → Just adds regex replace to strip out HTML tags.
Attachment #224456 - Flags: superreview?(mconnor)
We can also provide "do you mean" suggestion from built in spell check dictionary, regardless of entered spelling is correct or not (similar bug# 341715 )
Attachment #226838 - Flags: superreview?(mconnor)
Attachment #226838 - Flags: superreview+
Attachment #226838 - Flags: approval1.8.1+
Landed on branch & trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Verified Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: