Closed Bug 3405 Opened 26 years ago Closed 26 years ago

[PP]m3s: Mac crashes going to webpages not on local disk

Categories

(Core Graveyard :: Tracking, defect, P1)

PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mikepinkerton, Assigned: sfraser_bugs)

Details

Mac crashes when visiting any webpage not on the local drive. It dies in a callback probably in an interrupt handler. THe machine is toast at this point.
Summary: Mac crashes going to webpages not on local disk → m3s: Mac crashes going to webpages not on local disk
QA Contact: 3853 → 1698
danm suggests this is machine dependend and we started to see different behavior following scc's checkin... any more ideas on where to start the investigation on this?
I saw this in the morning before scc's checkins.
Assignee: chofmann → mcmullen
I heard that the Unix folks had a problem that was fixed after scc's checkin too. Maybe they have more info...
Linux had a problem of crashing on the second url loaded. When we pulled to get scc's checkin stuff, we also got errant checkins by troy and buster. It is concievable to me that some of those changes could have had an effect on the bug we were seeing. After clobbering and rebuilding, the apprunner can now visit >2 url's and be happy about it. I don't know what fixed it. troy touched the following 5 files in mozilla/layout/html/style/src/ nsCSSFrameConstructor.cpp nsCSSFrameConstructor.h nsTableFrame.cpp nsTableRowGroupFrame.cpp nsTableRowGroupFrame.h tomorrow, when I have a clean pull and build again, we will see if we have the same problem. It is possible that the act of clobbering and rebuilding could have fixed it as well. I really don't know. But this is unrelated to the mac crashing bugs
Component: Viewer App → Apprunner
Changed component to Apprunner.
Status: NEW → ASSIGNED
Assignee: mcmullen → saari
Status: ASSIGNED → NEW
Chris Saari is already investigating this, it seems. Reassigning to him.
Assignee: saari → sfraser
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
OK, we have a fix for this one now. It was the result of an apparently innocuous warnings fix on March 3, in mozilla/lib/mactime.c. The warnings fix changed macro expansion in a way that caused a routine to call itself recursively; the offending macro is #define ctime(t) Macctime(t) in xp_mcom.h So the crash occurred because tight recursion blew the stack very quickly.
sdagley is checkin in the fix right now.
Yes! great find... Thanks for the hard work in this one.
Yes! great find... Thanks for the hard work in this one.
Great. But two things: 1. There are three files called mactime.c in the tree. One of them is in NSPR, and is in use. 2. It's "daylight-saving time". (It's not a man-eatings tiger, but a man-eating tiger, see).
Yeah, and kudos to the person who #defined an existing routine name to something else. That's always a bad idea. The real fix for this problem would have been to change that #define.
Status: RESOLVED → VERIFIED
Verified fixed using 3.9.99 build on Mac OS (Apprunner checked). Broke side-issue raised by Simon/John into 3559.
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
Summary: m3s: Mac crashes going to webpages not on local disk → [PP]m3s: Mac crashes going to webpages not on local disk
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.