Closed
Bug 3411
Opened 26 years ago
Closed 26 years ago
View manager fails to check return values
Categories
(Core :: Layout, defect, P2)
Tracking
()
VERIFIED
FIXED
M3
People
(Reporter: sfraser_bugs, Assigned: michaelp)
References
Details
nsViewManager fails to check return values for some calls that can quite
easily fail. E.g. in nsViewManager::GetDrawingSurface(), the call to
aContext.CreateDrawingSurface() can fail, but the return value is
ignored. This caused us a nasty crashing bug on Mac.
fixed in my local tree. i'll check it in when the tree opens. since this isn't
the cause of the crash (it would merely mask bad behavior elesewhere), it's
probably not a good idea to check it in until the other issues associated with
the crash have been addressed. unless, of course, we're so desperate to get the
tree open that we don't really care about fixing the real bug... :)
Comment 3•26 years ago
|
||
A question though: when GetDrawingSurface() fails, we just draw directly on the
screen, right?
that would be the correct thing to do yes. i'd have to look to make sure that
we correctly fall back today, but that is the idea. i'll make sure that this is
the case when i check in the first fix.
Updated•26 years ago
|
Target Milestone: M3
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → REOPENED
Reporter | ||
Updated•26 years ago
|
Resolution: FIXED → ---
Reporter | ||
Comment 6•26 years ago
|
||
This bug should not have been closed as a dup of 3403. That bug addresses
the crash, the real cause of which was the NSPR memory leak. This bug relates
to the view manager failing to check return values, and I don't think michaelp
has checked in fixes there yet, so this bug should stay open until those changes
are checked in.
i have no idea about the dup status, but i checked in view manager fixes
yesterday. you guys can sort it out from here...
Reporter | ||
Updated•26 years ago
|
Status: REOPENED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•26 years ago
|
||
I stand corrected. Closing again.
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 9•26 years ago
|
||
Fixed in March 9th Build.
You need to log in
before you can comment on or make changes to this bug.
Description
•