Closed
Bug 342929
Opened 19 years ago
Closed 18 years ago
outline on <iframe> triggers "WARNING: Hmm, outline painting should always find an overflow area here"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
VERIFIED
WORKSFORME
People
(Reporter: jruderman, Assigned: sharparrow1)
References
Details
(Keywords: testcase)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
The testcase triggers
WARNING: Hmm, outline painting should always find an overflow area here: file /Users/admin/trunk/mozilla/layout/base/nsCSSRendering.cpp, line 2148
|
Reporter | |
Comment 1•19 years ago
|
||
|
Assignee | |
Comment 2•19 years ago
|
||
Looks like nsFrameFrame::Reflow needs to call FinishAndStoreOverflow(); I think all that needs to be done is to add:
aDesiredSize.mOverflowArea = nsRect(0, 0, aDesiredSize.width,
aDesiredSize.height);
FinishAndStoreOverflow(&aDesiredSize);
just before the NS_FRAME_TRACE call in nsFrameFrame::Reflow.
I don't have a tree I can make a patch against easily, though.
|
||
Comment 3•19 years ago
|
||
What Eli proposed above. This makes the assertion go away and the outline is
now painted correctly. Tested on SeaMonkey Linux.
|
|
||
Updated•19 years ago
|
Assignee: nobody → sharparrow1
OS: Mac OS X 10.4 → All
Hardware: Macintosh → All
|
|
Assignee | |
Updated•19 years ago
|
Attachment #227378 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 4•19 years ago
|
||
dbaron, should I ask someone else for review?
|
||
Updated•19 years ago
|
Attachment #227378 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 5•18 years ago
|
||
Oops, forgot about this patch; sorry about that.
However, it looks like this issue has been fixed; marking worksforme.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•