Closed
Bug 343800
Opened 18 years ago
Closed 18 years ago
SetBoolPref can store ints in memory
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
(deleted),
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
PREF_SetBoolPref does not make sure that it is only storing PR_TRUE or PR_FALSE. This means that code that later checks a pref set by PREF_SetBoolPref earlier may get a return value that is neither PR_TRUE or PR_FALSE. However, once the pref is saved to disk and then restored from disk after a restart, the code will get either PR_TRUE or PR_FALSE. This isn't good. This is the root cause of bug 317033.
|
Assignee | |
Comment 1•18 years ago
|
||
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking1.8.1?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #228349 -
Flags: superreview?(darin)
|
||
Updated•18 years ago
|
Attachment #228349 -
Flags: superreview?(darin)
Attachment #228349 -
Flags: superreview+
Attachment #228349 -
Flags: review?(darin)
Attachment #228349 -
Flags: review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checked in on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #228349 -
Flags: approval1.8.1?
|
|
||
Updated•18 years ago
|
Attachment #228349 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Updated•18 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•