Closed Bug 344984 Opened 18 years ago Closed 18 years ago

Make unknownContentType.xul dialog look better

Categories

(Firefox :: File Handling, defect)

Product:
Firefox
Component:
File Handling
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: mwu, Assigned: mwu)

References

Details

(Keywords: fixed1.8.1, polish)

Attachments

(6 files, 4 obsolete files)

Before (linux)
(deleted), image/png
Details
After (linux)
(deleted), image/png
Details
After (linux, alternative)
(deleted), image/png
Details
Before (WinXP)
(deleted), image/png
Details
After (WinXP)
(deleted), image/png
Details
Move things a little, v4
(deleted), patch
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review
Some small adjustments to the xul can be made to improve the look of this dialog.
Assignee: nobody → michael.wu
Attached image Before (linux) (deleted) —
Attached patch WIP: Move things a little (obsolete) (deleted) — — Splinter Review
Attached image After (linux) (deleted) —
Keywords: polish
Attached patch WIP: Another possibility (obsolete) (deleted) — — Splinter Review
Attached image After (linux, alternative) (deleted) —
Attached patch WIP: Move things a little, v2 (obsolete) (deleted) — — Splinter Review
Make work on OSX.
Attachment #229553 - Attachment is obsolete: true
Attached patch Move things a little, v3 (obsolete) (deleted) — — Splinter Review
Attachment #229557 - Attachment is obsolete: true
Attachment #229627 - Attachment is obsolete: true
Attached image Before (WinXP) (deleted) —
Attached image After (WinXP) (deleted) —
Attachment #229926 - Flags: ui-review?(beltzner)
Attachment #229926 - Flags: review?(mconnor)
Attachment #229926 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 229926 [details] [diff] [review] Move things a little, v3 r=me, assuming you test this in RTL, since I think we should be using -moz-margin-start and -moz-margin-end instead of left and right
Attachment #229926 - Flags: review?(mconnor) → review+
Attached patch Move things a little, v4 (deleted) — — Splinter Review
Fixed RTL issues according to mconnor's comment.
Attachment #229926 - Attachment is obsolete: true
Whiteboard: [checkin needed]
mozilla/toolkit/themes/winstripe/mozapps/downloads/unknownContentType.css 1.4 mozilla/toolkit/mozapps/downloads/content/unknownContentType.xul 1.14 mozilla/toolkit/themes/pinstripe/mozapps/downloads/unknownContentType.css 1.3
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [needs approval]
Version: Trunk → 2.0 Branch
Comment on attachment 231027 [details] [diff] [review] Move things a little, v4 This is a fairly safe change which improves the look of unknownContentType.xul on all platforms.
Attachment #231027 - Flags: approval1.8.1?
Comment on attachment 231027 [details] [diff] [review] Move things a little, v4 approved by schrep for drivers
Attachment #231027 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [needs approval] → [checkin needed (1.8 branch)]
Landed on branch Checking in toolkit/mozapps/downloads/content/unknownContentType.xul; /cvsroot/mozilla/toolkit/mozapps/downloads/content/unknownContentType.xul,v <-- unknownContentType.xul new revision: 1.11.2.2; previous revision: 1.11.2.1 done Checking in toolkit/themes/pinstripe/mozapps/downloads/unknownContentType.css; /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/unknownContentType.css,v <-- unknownContentType.css new revision: 1.2.26.1; previous revision: 1.2 done Checking in toolkit/themes/winstripe/mozapps/downloads/unknownContentType.css; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/unknownContentType.css,v <-- unknownContentType.css new revision: 1.3.8.1; previous revision: 1.3 done
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: