User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060718 Minefield/3.0a1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060718 Minefield/3.0a1 Up/down arrows on vertical scrollbars are nonfunctional Reproducible: Always Steps to Reproduce: 1. Left click up or down arrow on vertical scrollbar 2. 3. Actual Results: no scrolling Expected Results: scrolling Since checkin of bug 303048 perhaps?

Using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060718 Minefield/3.0a1 ID:2006071817 [cairo]

I backed out bug 303048 locally and I'm not seeing this. Looks like this is regression from it.

Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060719 Minefield/3.0a1 ID:2006071903 [cairo]

mwu pointed out that I wasn't returning anything most of the time in this function. Not sure if this is the root cause of the problem, though...

When I change this code (in nsscrollbarbuttonframe.cpp) from instead to returning false: if (NS_FAILED(aPresContext->LookAndFeel()->GetMetric(tmpAction, pressedButtonAction))) from: return PR_FALSE; to: pressedButtonAction = 0; I get the scrolling working again.

This fixes it for me.

This will fix stuff, but I'm still trying to figure out how a trunk build I pulled and compiled from CVS is not making scrollbars active when I right or middle click them, but my own build that I originally made this patch in is.

(In reply to comment #7) > I'm still trying to figure out how a trunk build I > pulled and compiled from CVS is not making scrollbars active when I right or > middle click them, but my own build that I originally made this patch in is. That's probably a separate bug that we should fix separately.

Comment on attachment 229888 [details] [diff] [review] patch to fix good to go

I filed bug 345245 for the issue I mentioned in comment 7.

Checking in widget/src/gtk2/nsLookAndFeel.cpp; /cvsroot/mozilla/widget/src/gtk2/nsLookAndFeel.cpp,v <-- nsLookAndFeel.cpp new revision: 1.29; previous revision: 1.28 done Checking in widget/src/xpwidgets/nsXPLookAndFeel.cpp; /cvsroot/mozilla/widget/src/xpwidgets/nsXPLookAndFeel.cpp,v <-- nsXPLookAndFee l.cpp new revision: 1.52; previous revision: 1.51 done Checking in layout/xul/base/src/nsScrollbarButtonFrame.cpp; /cvsroot/mozilla/layout/xul/base/src/nsScrollbarButtonFrame.cpp,v <-- nsScroll barButtonFrame.cpp new revision: 1.48; previous revision: 1.47 done Checked into trunk.

Comment on attachment 229888 [details] [diff] [review] patch to fix If you're not going to use the prefs you might as well #ifdef the scrollbar button code...

*** Bug 345273 has been marked as a duplicate of this bug. ***