Closed
Bug 345564
Opened 18 years ago
Closed 18 years ago
Hang during login to financial institution site
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: greatnessguru, Assigned: mark)
References
()
Details
(Keywords: fixed1.8.1, hang, regression)
Attachments
(3 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
jaas
:
review+
mikepinkerton
:
superreview+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 Build Identifier: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8/firefox-2.0b1.en-US.mac.dmg - 17967 KB 21/7/2006 23:05:00 After Entering Member Number and Password, the next screen Hangs "Transferring data from ...". Page is all white. Cannot make BonEcho Stop the transfer, nor Quit except via Force Quit. Reproducible: Always Steps to Reproduce: 1. Enter Member Number and Password 2. Click ENTER 3. next screen Hangs "Transferring data from ...". Page is all white. Thank you, Eddie Maddox
Reporter | ||
Comment 1•18 years ago
|
||
(In reply to comment #0) > User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; > rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 Correction: Firefox-2.0b1, and Firefox-2.0b1 17967 KB 21/7/2006 23:05:00 nightly Regression from Firefox 1.5.0.x, where login works, no hangs.
Flags: blocking-firefox2?
Version: unspecified → 2.0 Branch
Comment 2•18 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060721 BonEcho/2.0b1 I get a member Verification Error, no hang.
Reporter | ||
Comment 3•18 years ago
|
||
(In reply to comment #2) > Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060721 > BonEcho/2.0b1 > I get a member Verification Error, no hang. So, it works on Windows? I'm using Mac OSX 10.3.latest on a blue G3. Eddie
Comment 4•18 years ago
|
||
Please only nominate for blocking once this bug is confirmed.
Flags: blocking-firefox2?
Keywords: qawanted
Comment 5•18 years ago
|
||
Confirming. This is a regression from 1.5. I noticed that in 1.5 I see two modal dialogs saying something about my password after the "member verification error" page has loaded. Judging from the stack, it looks like this could have something to do with the hang.
Severity: critical → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox2?
Summary: Hang during login to financial institution site. Regression. → Hang during login to financial institution site
Comment 6•18 years ago
|
||
I hope this is of some use. This is my first time using the Sampler program.
Comment 7•18 years ago
|
||
This appears to be Mac-only. I'm pretty convinced that it has something to do with how the "sheets" for modal dialogs are shown.
Assignee | ||
Comment 8•18 years ago
|
||
Member verificiation error, no sheets, no hang using a bogus ID and password. Same behavior 1.5.0.5 and 2b-nightly. Is there some special ID and password I should try?
Assignee | ||
Comment 9•18 years ago
|
||
Comment on attachment 231701 [details]
trace from Sampler.app
This stack shows three ShowModal calls piled up on top of each other. Those of you who see the sheets, can you tell me what dialogs this site wants to display in a working build (1.5.0.5 or on a different OS?)
Reporter | ||
Comment 10•18 years ago
|
||
(In reply to comment #9) > (From update of attachment 231701 [details] [edit]) > This stack shows three ShowModal calls piled up on top of each other. Those of > you who see the sheets, can you tell me what dialogs this site wants to display > in a working build (1.5.0.5 or on a different OS?) Sounds like Camino Bug 325306, only there, instead of hanging, the sheets do not go away and Quit does not work. Force Quit is needed to kill Camino. Eddie
Assignee | ||
Comment 11•18 years ago
|
||
Can someone please supply an ID and password (OK if they're bogus) that exhibit this bug? I'm unable to reproduce it in a current Bone Cho build with a clean profile. This is going to be really hard to diagnose otherwise. Eddie, do you have any extensions that might be throwing sheets? Do you have any passwords saved for the site? (BonEcho:Preferences:Security:Show Passwords…)
Comment 12•18 years ago
|
||
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1 These are the steps I used to reproduce this using the build above (with a clean profile). 1. Go to http://usfed.org/. 2. Type "123456" for the member number and "test" for the password. 3. Hit enter. After a few seconds I get taken to the "member verification error" page and am hung.
Comment 13•18 years ago
|
||
Clearing. Adam, can you verify that you get hung with Fx2b1? I'm using that atm due to the number of hangs I'm getting with nightly Bon Echo builds and can't reproduce this bug.
Flags: blocking-firefox2?
Assignee | ||
Comment 14•18 years ago
|
||
I get a pair of dialogs in 2b1 on Linux, but no dialogs in 2b-nightly on Windows or Mac. I do get a pair of sheets in 1.5.0.5 on Mac ppc, but not on Mac x86. I haven't been able to get the sheets (and thus the hang) in a configuration that should hang according to this bug (2b). Constistency is great, isn't it?
Comment 15•18 years ago
|
||
I see the same hang with Firefox 2 beta 1. Maybe this is PPC-specific.
Assignee | ||
Comment 16•18 years ago
|
||
I was eventually able to reproduce some bogus behavior, thanks to Adam's insistence.
Assignee: nobody → mark
Flags: blocking-firefox2?
Comment 17•18 years ago
|
||
tested on Mac PPC 10.4.7, build id 2006080204. member verification error. No hang.
Assignee | ||
Comment 18•18 years ago
|
||
The steps to reproduce should be made more clear: press the RETURN key, don't click ENTER with the mouse. When I experience this, I see the "member Verification Error" page (way to go, capitalization, folks!), but there's no indication that anything is hung at that point. Note that, as stated in comment 0, the status bar still says "Transferring data from www.usfed.org…". The progress spinner will appear active but be stalled. The cursor spinner will be spinning, and some functions will appear to work. At this point, you will probably still be able to close the window with few ill effects, although the ill effects may just be delayed. However, if you attempt to interact with the window at this point, you'll wind up wedged more solidly. Press command-D (add bookmark), for example. Before the app is entirely hung, you may be able to quit and experience an interesting show of sheets showing and hiding and windows moving around and drawing entirely in white. It appears that we're getting into a state where a modal loop is waiting for the user to click on an "OK" button in a sheet that's never displayed. I've worked on bugs like this one before. The system becomes very annoyed when you try to attach more than one sheet to a single window at a time.
Assignee | ||
Comment 19•18 years ago
|
||
I haven't been able to reproduce in Meinfeld. (Possibly due to the new threadmanager?)
Assignee | ||
Comment 20•18 years ago
|
||
Adam, would you mind banging on this and letting me know how it works? Some other things to test are the multiple-sibling sheet testcase in bug 312586 (maybe modified to be more rigorous, like showing more sheets at closer intervals for "green") and parent-child sheet cases like "New Folder…" in the "Add Bookmark" sheet and all of the stuff that the Google Toolbar throws up after installing it for the first time. I notice that even with this patch, we're missing the application icon in the sheet if it hasn't been loaded yet at the time the usfed.org sheets are thrown. I think that this is because of all of the stacked loops that we're getting, and I think that there's no feasible way to do anything about it on the branch.
Assignee | ||
Comment 21•18 years ago
|
||
I don't know if this is neccessary. Something would have to try to throw multiple sheets simultaneously. The usfed.org test case only throws a single sheet on the trunk (due to the threadmanager?)
Comment 22•18 years ago
|
||
I verified that I was seeing this hang in my debug build before applying the patch. After applying the patch I don't see the hang anymore, just three of those sheets telling me that my password isn't between 4 and 8 characters. After closing the last sheet I see these assertion: ###!!! ASSERTION: attempted to dispatch gui event to null widget: 'aWidget', file /Users/aguthrie/moz/branch/mozilla/widget/src/mac/nsMacEventHandler.cpp, line 118 Break: at file /Users/aguthrie/moz/branch/mozilla/widget/src/mac/nsMacEventHandler.cpp, line 118 --WEBSHELL == 3 ###!!! ASSERTION: Attempt to decrement focus controller's suppression when no suppression active! : 'PR_FALSE', file /Users/aguthrie/moz/branch/mozilla/dom/src/base/nsFocusController.cpp, line 514 I don't know if these are bad or not, of even if they are an effect of Mark's patch. I'll leave that up to the pros to decide.
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Updated•18 years ago
|
Target Milestone: --- → Firefox 2
Comment 23•18 years ago
|
||
Mark, were you going to ask for review on the "Test THIS" patch?
Assignee | ||
Comment 24•18 years ago
|
||
Comment on attachment 231862 [details] [diff] [review] Test THIS Oops, yeah.
Attachment #231862 -
Flags: review?(joshmoz)
Reporter | ||
Comment 25•18 years ago
|
||
(In reply to comment #22) > ... After applying the patch I don't see the hang anymore, just three of > those sheets telling me that my password isn't between 4 and 8 characters. > ... 1. Regression: "just three of those sheets"... just two of those sheets are shown with Ff 1.5 and (IIRC) Camino. 2. Is it a bug when "those sheets telling me that my password isn't between 4 and 8 characters" are shown even when my password is between 4 and 8 characters inclusive? That happens, even though I have an account there and am able to log in (Ff 1.5). Please see Camino Bug 325306: ------- Comment #12 From Eddie Maddox 2006-02-01 09:28 PDT [reply] ------- (In reply to comment #11) > We're spawning alerts recursively on the stack. ... However, one more funny about this: that "Please enter a password between 4 and 8 characters long. [OK]" error sheet drops down Even when the password Is 4-8 characters long. Is this part of the problem due to my financial institution's server code (JavaScript?), or is this a Camino bug, too? _____ Do I need to file a Bug Report on just these "4-8 characters" sheets being shown in the first place? Is this a case of one bug ("4-8 characters" sheets) triggering other bugs in Ff and Camino? Are we only fixing the follow-on bug (the hang) in Ff2 with the patch above while the triggering bug ("4-8 characters" sheets), and the follow-on bug in Camino ("Dialog box won't go away, and Camino won't Quit.") stay broken? Thanks, Eddie
Attachment #231862 -
Flags: review?(joshmoz) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #231862 -
Flags: superreview?(mikepinkerton)
Comment 26•18 years ago
|
||
Comment on attachment 231862 [details] [diff] [review] Test THIS sr=pink so complicated. sigh.
Attachment #231862 -
Flags: superreview?(mikepinkerton) → superreview+
Assignee | ||
Comment 27•18 years ago
|
||
Comment on attachment 231862 [details] [diff] [review] Test THIS I'm not going to check this in on the trunk because the new thread manager fixes the underlying architectural problem, and I don't want to add complexity where it's not needed.
Attachment #231862 -
Flags: approval1.8.1?
Comment 28•18 years ago
|
||
Comment on attachment 231862 [details] [diff] [review] Test THIS a=schrep for drivers.
Attachment #231862 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 29•18 years ago
|
||
Fixed on MOZILLA_1_8_BRANCH before 1.8.1rc1. Re comment 25: 1. There should really only be one sheet, but there's an underlying bug here with event queues that's causing more than one of the same sheet to be displayed. There's a bug on it, but it was marked fixed when the new thread manager landed (on the trunk). I can't find that bug easily now - it's in my list, but apparently doesn't have the word "queue" in the first 60 characters of the title. 2. That's a bug, but it's not our bug, it's a bug with the site. It only does that when you press the return key instead of clicking on the "enter" image.
You need to log in
before you can comment on or make changes to this bug.
Description
•