Closed Bug 347040 Opened 18 years ago Closed 18 years ago

outline is rendered with Anti-aliasing

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: masayuki, Assigned: masayuki)

References

(
URL
)

Details

Attachments

(2 files)

testcase
(deleted), text/html
Details
Patch rv1.0
(deleted), patch
vlad
: review+
dbaron
: superreview-
Details | Diff | Splinter Review
The borders don't rendered with anti-aliasing. But the outlines don't so. I think we should not render the outlines with anti-aliasing.
Attached file testcase (deleted) —
the border case of the test case is here. attachment 178528 [details]
Attached patch Patch rv1.0 (deleted) — — Splinter Review
This patch based on the patch of bug 328241. Even if we will enable the anti-aliasing for border, we should disable anti-aliasing for outline until then for compatibility between border and outline.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #231948 - Flags: review?(vladimir)
The patch changes |nsCSSRendering::PaintOutline|.
OS: Windows 2000 → All
Hardware: PC → All
Attachment #231948 - Flags: superreview?(dbaron)
Shouldn't the second chunk restore it to whatever it was before rather than explicitly setting it to MODE_COVERAGE?
You are right, but the my patch is based on the patch of bug 328241. https://bugzilla.mozilla.org/attachment.cgi?id=219188&action=diff Vlad: How do you think?
Oops, I should have made the same review comment there.
this is fixed by bug 368247.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Depends on: 368247
Resolution: --- → FIXED
Attachment #231948 - Flags: superreview?(dbaron)
Attachment #231948 - Flags: superreview-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: