Closed
Bug 350739
Opened 18 years ago
Closed 18 years ago
Drop down buttons are too wide
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ispiked, Assigned: enndeakin)
References
Details
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
asaf
:
first-review+
neil
:
second-review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060830 Minefield/3.0a1
After the patch for bug 348614, the width of drop down buttons, e.g. the all tabs button and back/forward buttons increased.
Personally, I don't like this change. Was the change in appearance intentional? I thought it was more of a consolidation than an appearance change.
Assignee | ||
Comment 1•18 years ago
|
||
No, no changes to the appearance were intended.
Comment 2•18 years ago
|
||
Neil, can you take this? This is also breaking the alltabs-button on trunk.
Comment 3•18 years ago
|
||
Also, I see this in Pinstripe too.
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Comment 4•18 years ago
|
||
If the change was intended, the alltabs-button's background image could be widened.
Assignee | ||
Comment 5•18 years ago
|
||
It wasn't intended. I'm currently testing a fix.
Assignee: nobody → enndeakin
Status: ASSIGNED → NEW
Comment 6•18 years ago
|
||
Comment 7•18 years ago
|
||
*** Bug 353879 has been marked as a duplicate of this bug. ***
Comment 8•18 years ago
|
||
additionally, you can see the effect of this bug on the hover state of the back / fwd buttons (when they are enabled)
Comment 9•18 years ago
|
||
Assignee | ||
Comment 10•18 years ago
|
||
The Mac toolkit seemed to be using different images for the dropmarkers than all other themes (even Mac Seamonkey). I changed the images back to this different set, although maybe we should try for consistency?
Attachment #240154 -
Flags: second-review?(neil)
Attachment #240154 -
Flags: first-review?(mano)
Comment 11•18 years ago
|
||
Comment on attachment 240154 [details] [diff] [review]
Fix width of dropmarkers
Does the auto width need to be important? (I'd hope not but didn't try it)
Attachment #240154 -
Flags: second-review?(neil) → second-review+
Comment 12•18 years ago
|
||
Comment on attachment 240154 [details] [diff] [review]
Fix width of dropmarkers
r=mano
Attachment #240154 -
Flags: first-review?(mano) → first-review+
Assignee | ||
Comment 13•18 years ago
|
||
Checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•