Closed Bug 356978 Opened 18 years ago Closed 18 years ago

[FIX]popup fails

Categories

(Core :: DOM: Core & HTML, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9alpha1

People

(Reporter: Peter6, Assigned: bzbarsky)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061017 Minefield/3.0a1 ID:2006101700 [cairo] repro: 1. go to http://www.knmi.nl/actueel/ 2. click on one of the 4 maps result: no popup with an enlarged version of the image Works in the 20061016 nightly fails in the 20061017 nightly http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20061016+035000&maxdate=20061017+035000&cvsroot=%2Fcvsroot regression from bug 351633 ?
Minimal testcase: data:text/html,<a href="javascript:void(window.open())">Click me</a> This is a regression from bug 351633.
Blocks: 351633
Assignee: nobody → general
Component: General → DOM
OS: Windows 2000 → All
Priority: -- → P1
Product: Firefox → Core
QA Contact: general → ian
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
Attached patch Fix (deleted) — Splinter Review
Kinda wish we could in general propagate the popup control state to channels when doing AsyncOpen....
Assignee: general → bzbarsky
Status: NEW → ASSIGNED
Attachment #242536 - Flags: superreview?(jst)
Attachment #242536 - Flags: review?(jst)
Summary: popup fails → [FIX]popup fails
Comment on attachment 242536 [details] [diff] [review] Fix r+sr=jst
Attachment #242536 - Flags: superreview?(jst)
Attachment #242536 - Flags: superreview+
Attachment #242536 - Flags: review?(jst)
Attachment #242536 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061018 Minefield/3.0a1 ID:2006101823 [cairo] verified/fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Gecko 2006/1003 Confirmed working.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: