Closed Bug 3579 Opened 26 years ago Closed 25 years ago

[CODE CLEANUP] Change CLSID to ClassID

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dp, Assigned: sford4)

Details

Attachments

(9 files)

js diff
(deleted), patch
Details | Diff | Splinter Review
layout diff
(deleted), patch
Details | Diff | Splinter Review
mailnews diff1
(deleted), patch
Details | Diff | Splinter Review
mailnews diff2
(deleted), patch
Details | Diff | Splinter Review
rdf diff 2
(deleted), patch
Details | Diff | Splinter Review
webshell diff 1
(deleted), patch
Details | Diff | Splinter Review
webshell diff 2
(deleted), patch
Details | Diff | Splinter Review
xmlterm diff
(deleted), patch
Details | Diff | Splinter Review
xpcom diff
(deleted), patch
Details | Diff | Splinter Review
What do you think about making these other changes too (for xidl): remove reference parameters, remove default parameters (in service manager), rename ProgIDToCLSID to ProgIDToClassID (as per Brendan's suggestion).
removing default parameters is probably fine. removing reference parameters is definitely wrong. normal (MS) COM supports them, we should to. We've had this discussion before. I like the change ProgIDToCLSID --> ProgIDToClassID. The question is: why is this bug assigned to me and not to shaver or vidur? They are the IDL owners. Or is the bug just a Request For Comments?
Assignee: scc → dp
I wanted to assign this to myself. Yuck.
Target Milestone: M4
Status: NEW → ASSIGNED
Target Milestone: M4 → M5
Target Milestone: M5 → M6
moving off to m6
Target Milestone: M6 → M8
Summary: Need idl → API: Change CLSID to ClassID
Target Milestone: M8 → M10
Summary: API: Change CLSID to ClassID → [CODE CLEANUP] Change CLSID to ClassID
Target Milestone: M10 → M12
Target Milestone: M12 → M16
Assignee: dp → sford4
Status: ASSIGNED → NEW
I am working on this bug and wanted to know if we wanted to change both instances to ProgIDToClassID, one in nsRepository and one in nsComponentManager. I will take the bug as well.
If we change them, it would be best to change them both. Thanks for doing this!
Status: NEW → ASSIGNED
Attached patch js diff (deleted) — — Splinter Review
Attached patch layout diff (deleted) — — Splinter Review
Attached patch mailnews diff1 (deleted) — — Splinter Review
Attached patch mailnews diff2 (deleted) — — Splinter Review
Attached patch rdf diff 2 (deleted) — — Splinter Review
Attached patch webshell diff 1 (deleted) — — Splinter Review
Attached patch webshell diff 2 (deleted) — — Splinter Review
Attached patch xmlterm diff (deleted) — — Splinter Review
Attached patch xpcom diff (deleted) — — Splinter Review
If someone can review this patch I can check it in.
The XPCOM patch looks good to me Chris... do you want me to review all of them?
If possible, yeah.
Ok, I'm running these changes. They look sane. Can I get someone-who-cares to say it's ok to check it in?
They all look OK to me. At least, I didn't see anything that stuck out as stupid. If everything is running, then go ahead and check it in ... r=scc.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Checked in.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: