Closed Bug 3598 Opened 26 years ago Closed 26 years ago

apprunner needs to call nsIPref->Startup()

Categories

(Core :: Preferences: Backend, defect, P1)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: hshaw, Assigned: hshaw)

Details

for now: unix ~/.mozilla/prefs.js windows/max program_dir/prefs.js
Severity: normal → critical
Priority: P3 → P1
Target Milestone: M3
Version: other
Status: NEW → ASSIGNED
Accepting this bug. Should tested and checked in tonight.
I checked in something to at least read prefs.js from startup directory on all platforms for apprunner. I wanted to checkin something slightly more flexible that utilized nsSpecialSystemDirectory but this introduced a new dependency for libpref (raptorbase) I didn't have any way of modifying the mac project files to reflect the new depenency and was fearful of breaking the mac build so checked in the simpler version.
Upon reviewing my checkin for last night, I realized I forgot to checkin on of the files. With what is currently checked in, if you use the nsIPref interface, the default pref file will be read in. However if you're still using the old PREF_* prefapi.c API, the default pref file is not read in. I have prefapi.c ready for checkin if I can get approval.
Asking chofmann for permission to checkin a file I missed in my checkin last night. The pref file initialization work-around needs to happen in two places. Since I missed a file, it only happens in one place now. The version of the change which needs a change to the Mac project files, I'm holding off until I can test on Mac builds.
You got permission!
Fix checked in. All prefs.js read in from the current directory. We will change it to right directory after M3.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
So there isn't any confusion, the pref file being read on the various platforms is: win: prefs.js mac: Netscape Preferences unix: preferences.js For M3 they are being read from the current working directory. This will change shortly after M3.
Can someone give me a valid pref so I can verify this? I tried the old broswer.startup.homepage but that didn't seem to do anything. Something where I can easily verify that the prefs file is being read (on all platforms). Thanks.
Status: RESOLVED → VERIFIED
okay verified that this works on Mac/Windows using some proxy settings. Sounds like Unix has some of it's own problems, there is a separate bug filed for this.
Moving all libPref component bugs to new Preferences: Backend component. libPref component will be deleted.
Component: libPref → Preferences: Backend
You need to log in before you can comment on or make changes to this bug.