Closed
Bug 360847
Opened 18 years ago
Closed 18 years ago
Remove unused nsIDOM*foo*Listener interfaces
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
Details
(Keywords: dev-doc-complete, Whiteboard: See comment 13)
Attachments
(2 files)
(deleted),
patch
|
jst
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
We could perhaps clean up / remove some DOM Events related interface already in 1.9.
See also http://wiki.mozilla.org/Gecko:Obsolete_API
Assignee | ||
Comment 1•18 years ago
|
||
Can we make this kind of change for 1.9? Would this break some binary extension? Though, converting to use nsIDOMEventListener should be trivial.
Attachment #245704 -
Flags: review?(jst)
Comment 2•18 years ago
|
||
Comment on attachment 245704 [details] [diff] [review]
possible patch
*I* think we should do this for 1.9, but I'll leave the final decision about that to the 1.9 triaging meetings. r=jst either way!
Attachment #245704 -
Flags: review?(jst) → review+
Assignee | ||
Updated•18 years ago
|
Flags: blocking1.9?
Assignee | ||
Updated•18 years ago
|
Attachment #245704 -
Flags: superreview?(bugmail)
Assignee | ||
Comment 3•18 years ago
|
||
I hope I can remove nsIDOMEventReceiver (Bug 363089), so possibly this could go in to 1.9 too.
And I wouldn't mind if all nsIDOM*foo*Listeners get removed even in 1.9
(http://wiki.mozilla.org/Gecko:Obsolete_API) .
Comment on attachment 245704 [details] [diff] [review]
possible patch
Yeah, I think we can do this. Though if people start screaming bloody murder we should consider putting them back for one more release.
In any case, please document in devmo how to migrate to other interfaces.
Attachment #245704 -
Flags: superreview?(bugmail) → superreview+
Comment 5•18 years ago
|
||
Smaug, this is not a blocker, but if you want to try to get this in for 1.9, I'd be all for that.
Flags: blocking1.9? → blocking1.9-
Assignee | ||
Comment 6•18 years ago
|
||
Does anyone object removing these interfaces?
If not, I'll check in the patch (needs some minor updates for trunk).
See comment 14 :)
Assignee | ||
Comment 8•18 years ago
|
||
Sent text to sheppy, hopefully will be in MDC soon.
Assignee | ||
Comment 9•18 years ago
|
||
Comment 10•17 years ago
|
||
None of the affected interfaces are documented, so unless there's something further that needs to be done, this issue is cleared in terms of documentation.
Keywords: dev-doc-needed → dev-doc-complete
Comment 11•17 years ago
|
||
I'm not seeing any mention of, say, nsIDOMMutationListener or nsIDOMPaintListener on devmo. Am I missing something?
Assignee | ||
Comment 12•17 years ago
|
||
This is the only place I found anything mentioned:
http://developer.mozilla.org/devnews/index.php/2007/02/13/removing-some-nsidomlistener-interfaces/
Maybe some better place for that information, because the normal search didn't
find that article when searching for for example nsIDOMPaintListener, or
apparently the devnews search is different than documentation search o_O
Comment 13•17 years ago
|
||
Basically, this change needs to be documented in the "changes since Gecko 1.8 for developers" section of things.
Keywords: dev-doc-complete → dev-doc-needed
Whiteboard: See comment 13
Comment 14•17 years ago
|
||
A description of this change has been added to the Fx3 for developers page. A Gecko changes page will be done later based on the contents of that page once things settle down a bit.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•