Closed
Bug 3624
Opened 26 years ago
Closed 26 years ago
crash - iframe - height percent attribute not honored
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect, P2)
Tracking
()
VERIFIED
FIXED
People
(Reporter: glynn, Assigned: buster)
References
()
Details
March 11 Seamonkey builds, Mac 8.5/G3, Linux 5.2, optimized, viewer
March 10 win98 optimized, viewer
1. Launch Seamonkey and load test case page: slip/projects/marvin/html/
frametest/iframe_height_percent.html
• Crash on Mac at PPC unmapped mem except at trim rect as page load is
attempted. On win98 page loads but iframes are not displayed properly and on
Linux page load finishes but page is displayed as all black with some graphic
fragments of the frames towards the top.
|
||
Updated•26 years ago
|
Assignee: karnaze → kipp
|
|
||
Comment 2•26 years ago
|
||
The reflow state passed into the <iframe>'s Reflow is not getting set properly.
In the following simple example, the reflow state has a constrained height, but
it turns out to be NS_UNCONSTRAINED_SIZE. The <iframe> then uses that height
causing the <iframe> to be too high. This needs to be fixed before figuring out
why the above url is crashing. It may solve that problem.
<body>
<iframe height=50% src=test1.html>
</body>
Here is what the <iframe>'s GetDesiredSize is doing:
if (aReflowState.HaveFixedContentHeight()) {
aDesiredSize.height = aReflowState.computedHeight;
}
I checked in a fix for this that uses the html reflow state properly; chris
should probably do more testing...
Reopened since crash still occurs in march 22, will recheck with Mar 23 builds
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
Kipp, the reason I had reopened it was it seemed your last entry indicated the
fix you made would facilitate a fix for this bug via chris, not that it actually
fixed this bug. Since you apparently meant your fix to be 'the' fix, I will
simply check this against tomorrow's builds and leave marked fixed as you reset
it.
Ok, crash is fixed but we still are not handling the percent quite correctly. I
have two iframes on the page set for 25% height but we are treating them as a
greater % as they take up 90% of the page height combined. Will file new bug and
mark this verified. Verified cross platform.
|
||
Comment 8•26 years ago
|
||
What is the bug number of the new bug? The new bug is now blocking mail/news in
two or three major UI components.
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•