Closed Bug 364266 Opened 18 years ago Closed 16 years ago

add drag-to-tabbar functionality for history menu items

Categories

(Firefox :: Bookmarks & History, enhancement)

2.0 Branch
x86
Windows XP
enhancement
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: stryker330, Unassigned)

Details

Attachments

(1 file)

It should be possible to drag the any of items within the history menu onto the tabbar, in the same way a link can be dragged to the tabbar. For ex: dragging a history menu item onto an open space on the tabbar would create a new tab whose page is set to that history menu item's URL. When dragging from the history menu, the dragged item isn't removed. In the same way a link would be dragged, the drag cursor should appear.
this works in firefox 2. this is a regression due to my history-on-places landing with the new history panel.
Depends on: 355738
Keywords: regression
Target Milestone: --- → Firefox 3 alpha1
Component: Tabbed Browser → Places
QA Contact: tabbed.browser → places
No this doesn't work in Firefox 2. I forgot to mention that I'm using the latest Firefox 2 build on a clean profile when testing this bug. I think you're misunderstanding what this bug/enhancement request is about. This has nothing to do with the history side-panel or the new places thing; it's about the History menu that can be accessed at very top b/w the View and Bookmarks menus. None of the items in that menu can be dragged onto the tabbar (or onto a tab's contents, for that matter).
you are right, I was mistaken. now I see what you are talking about. I also see that I can drag a bookmark menu item to the tabbar, so this should be doable. as for the bug I was thinking of (and seeing), see bug #364321
Component: Places → History
No longer depends on: 355738
Keywords: regression
Summary: add drag-to-tabbar functionality for history menu items → [RFE] add drag-to-tabbar functionality for history menu items
Target Milestone: Firefox 3 alpha1 → ---
Version: unspecified → 2.0 Branch
Summary: [RFE] add drag-to-tabbar functionality for history menu items → add drag-to-tabbar functionality for history menu items
Attached patch Patch (deleted) — Splinter Review
I think the History menu is much more suited to drag and drop than your other bug about the back and forward buttons.
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #253921 - Flags: review?(sspitzer)
QA Contact: places → history
Attachment #253921 - Flags: review?(mano)
Now that I think about it, it would be kind of redundant to have both History menu and back/forward dragging. But on the other hand, I don't see how it could hurt, since it would add a bit of UI consistency - namely anything containing a link should be draggable to the tabbar. Does this patch also work for the other items in the History menu, such as Home, Back, and Forward?
Comment on attachment 253921 [details] [diff] [review] Patch There's no reason to set the drag-start listener separately for each menu item, you can just apply it as you do for the drag-exit listener.
Attachment #253921 - Flags: review?(sspitzer)
Attachment #253921 - Flags: review?(mano)
Attachment #253921 - Flags: review-
Component: History → Bookmarks & History
QA Contact: history → bookmarks
WFM Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4pre) Gecko/20090330 Shiretoko/3.5b4pre
Assignee: ventnor.bugzilla → nobody
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: