Closed Bug 37001 Opened 25 years ago Closed 24 years ago

The browser would loop in nsUnknownDecoder and crash

Categories

(Core :: Networking, defect, P3)

All
Windows NT
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.1

People

(Reporter: ruslan, Assigned: rpotts)

References

Details

(Keywords: crash, Whiteboard: [nsbeta2-])

Attachments

(1 file)

The browser would loop in nsUnknownDecoder and crash when OnStartRequest is fired on error condition. To reproduce go access non-existent host.
Blocks: 25045, 35508
Keywords: nsbeta2
Target Milestone: --- → M17
ruslan, I am unable to reproduce this. I'm visiting a bogus host but can't reproduce it. I don't understand how the unknown decoder would even be envoked in this case.
Oops. Yes. Because my change is commented out. Go to nsHTTPResponseListener and uncomment lines at the end in nsHTTPFinalListener.
Adding crash keyword.
Keywords: crash
[nsbeta2-] since the problem is not currently compiled into the product
Whiteboard: [nsbeta2-]
Hold on. It blocks 25045,35508 .....
Target Milestone: M17 → Future
I see something like this now except it is from an OnStopRequest. Is this a different bug? Or is it this bug (even though the above seems to claim that this is not currently a problem)? I've seen this a few times. In the case I have a stack for it was when I clicked on a name in tinerbox. In that stack I've already 'ignored' a few of the asserts. It looked like it was going to keep asserting over and over again. I assume this would quickly blow the stack in a non-debug build. Have others been seeing this? I'll attach a stack
I'm seeing this stack blow-out too... For me it is when I access a https:// URL. I believe my PSM is not installed correctly. The cause of the recursion is the failure of nsIChannel::SetContentType() in nsUnknownDecoder::FireListenerNotifications(). see: http://lxr.mozilla.org/seamonkey/source/netwerk/streamconv/converters/nsUnknownDecoder.cpp#342 Since the content-type cannot be changed, when the URILoader's OnStartRequest() is called, it will create another UnknownDecode because the channel's content type is *still* application/x-unknown-content... I've attached a patch to bug #71498 which fixes this problem.
Depends on: 71498
I'll take this one because it's related to bug #71498 :-)
Assignee: valeski → rpotts
Target Milestone: Future → mozilla0.9.1
I've checked in the patch attached to bug #71498. So this sould be fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
VERIFIED on branch 2001060713 linux build. Leaving as resolved until the other platforms are checked.
QA Contact: tever → benc
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: