Closed
Bug 371450
Opened 18 years ago
Closed 5 years ago
nsFrame::IsContainingBlock should use nsStyleDisplay::IsBlockInside
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: dbaron, Unassigned)
Details
In bug 9458 comment 87, bzbarsky wrote:
> >@@ -3773,6 +3773,7 @@ nsFrame::IsFrameTreeTooDeep(const nsHTML
> > // Absolute positioning causes |display->mDisplay| to be set to block,
> > // if needed.
> > return display->mDisplay == NS_STYLE_DISPLAY_BLOCK ||
> >+ display->mDisplay == NS_STYLE_DISPLAY_INLINE_BLOCK ||
> > display->mDisplay == NS_STYLE_DISPLAY_LIST_ITEM ||
> > display->mDisplay == NS_STYLE_DISPLAY_TABLE_CELL;
>
> Huh. The function name in that "@@ .... @@" line is such a lie!
>
> Should the condition here basically be something like IsBlockInside()?
Updated•6 years ago
|
Product: Core → Core Graveyard
Assignee | ||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
Comment 1•5 years ago
|
||
I can't find any IsContainingBlock function, and I'm removing IsBlockInside in bug 1574107 since it's dead code.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 2•5 years ago
|
||
The code is probably now nsIFrame::GetContainingBlock
, which calls GetNearestBlockContainer
, which has tests for things that aren't containing blocks.
So I think this is no longer an issue.
You need to log in
before you can comment on or make changes to this bug.
Description
•