Closed Bug 3716 Opened 26 years ago Closed 25 years ago

[PP][BLOCK]crash selecting Bookmarks/Manage Bookmarks in apprunner

Categories

(Core Graveyard :: Tracking, defect, P3)

x86
All
defect

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 6823

People

(Reporter: danm.moz, Assigned: waterson)

Details

(Whiteboard: Regression caused by joki factoring out DOMEvent into two interfaces)

Launch apprunner built Saturday, 14 May 99, and select "Manage Bookmarks". It coredumps reliably on Linux for me. Windows crashes occasionally, and I've seen the Mac crash here at rare intervals. When it happens, the crash is always at the same spot: in the JavaScript executed to fulfill that menu command, fairly late; at the point where it's trying to find a native object to execute a function mentioned in the script. I don't pretend to understand this stuff, but I think the problem is actually in Layout or possibly RDF for all I know. JS is failing in nsJSEvent.cpp, line 106 after the line a->GetTarget(&prop) a is a musically named nsDOMEvent. It has no target, so during the attempt to GetTarget, it ends up in nsFrame::GetContent, which returns its mContent. mContent is null. Eventually, the JS makes a method call from the null content object and dies. Except the Mac, which doesn't die. Now that's scary.
Note I can't reproduce this bug with source pulled Monday morning, 15 Mar 99. The frame is no longer returning null content. I'm not closing the bug just yet, though I'm prepared to call it fixed when it comes back to me. (I'll just feel better if Troy or whoever tries it in a couple of days and still can't reproduce the problem.)
Assignee: troy → don
Component: Layout → Apprunner
Changing component to Apprunner
Resolved as WORKSFORME.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → VERIFIED
Works fine in the April 6th Build.
Status: VERIFIED → REOPENED
Status: REOPENED → RESOLVED
Closed: 26 years ago25 years ago
This still works fine. Who re-opened this bug?
Severity: normal → critical
QA Contact: 4144 → 4130
Resolution: WORKSFORME → ---
Summary: crash selecting Bookmarks/Manage Bookmarks in apprunner → [PP][BLOCK]crash selecting Bookmarks/Manage Bookmarks in apprunner
I put block in the summary because this has to work before bug 3675 can get worked out. It's a PP bug because the Mac works just fine. Let it be known I have stack traces for Linux and WinNT but talkback is acting up right now so it'll be a while. This bug is REOPENED because selecting Bookmarks|Manage Bookmarks now crashes reliably on Linux and NT as of the 5/20 and 5/19 builds respectively. I upped the severity, maybe someone can look at priority and milestone, Don?
Status: RESOLVED → REOPENED
reopening again because Don types faster than i do.
Assignee: don → slamm
Status: REOPENED → NEW
Target Milestone: M6
reassigning to slamm because he's on top of it. here's the linux stack trace I promised: Program received signal SIGILL, Illegal instruction. 0x840f631 in ?? () (gdb) bt #0 0x840f631 in ?? () #1 0x402ccb3b in NS_NewScriptEventListener () #2 0x403344b4 in js_GetProperty () #3 0x4032848e in js_Interpret () #4 0x40326dd0 in js_Invoke () #5 0x40326f75 in js_CallFunctionValue () #6 0x40311c99 in JS_CallFunctionValue () #7 0x402cc640 in nsJSEventListener::HandleEvent () #8 0x40963e09 in nsEventListenerManager::HandleEvent () #9 0x4078719d in RDFElementImpl::HandleDOMEvent () #10 0x407871f8 in RDFElementImpl::HandleDOMEvent () #11 0x40099a0a in nsMenuItem::DoCommand () #12 0x40099841 in nsMenuItem::MenuItemSelected () #13 0x4009a566 in menu_item_activate_handler () #14 0x80c41f6 in gtk_window_set_default_size () #15 0x809ce37 in gtk_signal_connect_object () #16 0x809c4be in gtk_signal_connect_object () #17 0x809abfa in gtk_selection_data_set () #18 0x80bc848 in gtk_widget_size_request () #19 0x808b9b5 in gtk_menu_shell_append () #20 0x808aeb6 in gtk_menu_shell_append () #21 0x80c3fdc in gtk_window_set_default_size () #22 0x809c4eb in gtk_signal_connect_object () #23 0x809abfa in gtk_selection_data_set () #24 0x80bc724 in gtk_widget_size_request () #25 0x8085d79 in gtk_get_current_event () #26 0x808531a in gtk_main_iteration_do () #27 0x80d31ab in gdk_input_add () #28 0x80e6130 in g_list_length () #29 0x80e65ab in g_list_length () #30 0x80e66c5 in g_main_iteration () #31 0x8084e2f in gtk_main () #32 0x4009281b in nsAppShell::Run () #33 0x40018da6 in nsAppShellService::Run () #34 0x8051313 in main ()
Robert and Chris, I see this in my build too. Should this bug belong to one of you? The bookmark file gets corrupted somehow. If I throw it away and pull a fresh one, I can manage bookmarks ok. I suspect adding bookmarks may have something to do with it.
Status: NEW → ASSIGNED
Reassigned to myself. I'll take a look.
Status: ASSIGNED → NEW
Steps I used to reproduce it. 1. Manage Bookmarks 2. Close it 3. Manage Bookmarks BOOM! Started again... 1. Manage Bookmarks BOOM! Has a nice rhythm, but you cannot dance to it.
Assignee: slamm → waterson
Status: NEW → ASSIGNED
Whiteboard: Regression caused by joki factoring out DOMEvent into two interfaces
This was caused by joki's checkin v1.68 nsRDFElement.cpp. Tracking him down...
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → DUPLICATE
This is a dup of 6823. *** This bug has been marked as a duplicate of 6823 ***
Status: RESOLVED → VERIFIED
VERIFIED dupe.
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.